Switch to positiv reporting

[ikstream]

Currently the analyzer reports which scripts are not supported, or analyzed yet. This might become incorrect if additional scripts are added on nmap's side.

Let's assume there is another rdp script added which we didn't recognize. Unfortunately it matches the scan configuration (e.g groups are safe and discovery only). The output of the script will be added to the scan output and the analyzer wont tell the user that the script wasn't evaluated for the analysis output.

Instead we should report which scripts have been used during the analysis.

I see a chance here to improve on #41 as well. If the analzyer provides a list of evaluated scripts to the parser, or the parser itself has a list of supported scripts we could print the message just once instead of every time the analyzer is run.

[4elta]

thanks for your contribution.

Let's assume there is another rdp script added which we didn't recognize. [...] The output of the script will be added to the scan output and the analyzer wont tell the user that the script wasn't evaluated for the analysis output.

that's a valid point.

i will update all Nmap parsers according the following schema:

1. loop over each script node
2. inside the loop parse specific script's output (based on the script's ID); continue at step 1.
3. should the script's ID contain the name of the service (e.g. dns, ssh, tls, etc.) inform the user about the fact that this script's ouput hasn't been parsed yet
   • this is primarily so the pentester can have a look at the script's output herself
   • but also so she can open an issue with the script's output, so i can implement a parser

i think it would add too much noise to print out a list of scripts that have been parsed.

regarding the issue of having multiple "Nmap script scan result not parsed: Githubissues.

Githubissues is a development platform for aggregating issues.