search

4finance / micro-infra-spring

Repository containing default microservice infrastructure set up using Spring configuration
Apache License 2.0
203 stars 49 forks source link

Bumping versions #641

Closed adrian-wozniak closed 6 years ago

adrian-wozniak commented 6 years ago

It's good to have newest versions of used libraries...

This PR update versions of almost all used 3rd parties.

The most important is Spring Cloud Edgware.RELEASE.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 74.471% when pulling 025662bd08cf4a59315dcc1d3b6d40c66b8ecccd on adrian-wozniak:bumping-versions into 59d56e53aabfc5d8a46ad543027ff38e08655625 on 4finance:master.

dstepanov commented 6 years ago

Can you rebase and describe your changes?

adrian-wozniak commented 6 years ago

@dstepanov Changes are at the top of master, I'll not squash them, cause I think reviewing commit by commit gives you possibility to focus on one change and see only code changes required by particular version updates. Some more details added as a comments near key changes.

dstepanov commented 6 years ago

Please squash your change so we have nice git log

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 74.535% when pulling 9132b789b16d5d1af1e3cefc78593b88ef3ae29d on adrian-wozniak:bumping-versions into 59d56e53aabfc5d8a46ad543027ff38e08655625 on 4finance:master.

adrian-wozniak commented 6 years ago

Sorry, but I'll not squash those commits. I want to have every version change separated to easily see why some code changes were done and actually this is how changes are committed to this repository. I really don't understand why you force me to do that. "Nice git log" is an argument that doesn't convince me, cause it has to be useful.

dstepanov commented 6 years ago

Well I guess it makes sense, I haven't seen PRs with 27 commits

adrian-wozniak commented 6 years ago

You can have PR with 100 commits... it's not a crime :). It's very valuable to see the way how whole change was created. It's easier to understand it. With squash you loose that ability, but if you want to see change as a whole than with small commits you're still able to do that.

dstepanov commented 6 years ago

I know people who have commit for every change in their code ;) Bumping lib version is enough for me.