4flixt / 2019_WNTR_Surrogate_Model

5 stars 2 forks source link

Water quality #6

Closed 4flixt closed 5 years ago

4flixt commented 5 years ago

Some questions regarding water quality:

acominola commented 5 years ago
4flixt commented 5 years ago

Thank you andrea! It took me way to long to understand that the unit of the age quality is just the age in seconds haha. I think, also considering your second point, we might want to switch to another marker to determine water quality or solely consider pressure and tank levels. My issue with the age (and especially the mixing rule) is that

sergiolucia commented 5 years ago

I shortly discussed with Andrea today:

4flixt commented 5 years ago

Ok so we wouldn't implement constraints but rather try to minimize the quality - that should work. In that case I would suggest to not learn the cluster mean+variance but instead the cluster max value. It also makes for a sleeker NN architecture. I‘ll still have to see how well the clustering generalizes, though. So far I have only been evaluating it with the training data set.

In any case I‘ve thought that its beneficial to learn two separate networks for pressure and quality.

I‘ll of course start with the pressure, such that we have more time making adaptions to the quality model etc.

Sergio Lucia notifications@github.com schrieb am Mo. 4. Nov. 2019 um 15:30:

I shortly discussed with Andrea today:

  • We agree that in general it would be great to have a very simple chlorine model. This will probably solve the problem of simulation-time-dependant values
  • Anyway in the case of age we could try to do the clustering for the pressure and just try to minimize the quality -- without specific bounds. Since the learning would not depend on the values themselves (0 order model) this might be enough?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/4flixt/2019_WNTR_Surrogate_Model/issues/6?email_source=notifications&email_token=AH2XOC6EFODGIQ25KFRW6FDQSAWXTA5CNFSM4JIMLBDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7N2TQ#issuecomment-549379406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2XOC2YAMTTP652B45KRCLQSAWXTANCNFSM4JIMLBDA .

sergiolucia commented 5 years ago

Yes, I agree that we should learn two separate models. One could even learn a third one for the levels of the tanks (which are the actual states and we should also learn...)

4flixt commented 5 years ago

Yes I have them in mind. These levels will effect water quality and pressure and we should have them as inputs to both models. I thought to have them as outputs of the pressure model (it is anyway just three states).

Sergio Lucia notifications@github.com schrieb am Mo. 4. Nov. 2019 um 15:41:

Yes, I agree that we should learn two separate models. One could even learn a third one for the levels of the tanks (which are the actual states and we should also learn...)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/4flixt/2019_WNTR_Surrogate_Model/issues/6?email_source=notifications&email_token=AH2XOC337AUBFFOB3OPQ5E3QSAYA5A5CNFSM4JIMLBDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7PCBA#issuecomment-549384452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2XOC25RPSR3H7M2IHSF5DQSAYA5ANCNFSM4JIMLBDA .

sergiolucia commented 5 years ago

looks good to me!

acominola commented 5 years ago

I agree, too :)