4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.
https://gdevelop.io
Other
11.05k stars 858 forks source link

Dialogue tree scrolling timing issues #1622

Open PascalLadalle opened 4 years ago

PascalLadalle commented 4 years ago

In the Dialogue tree example, when talking to the ant, the pause should be before the "I" is written, but it pauses after the "I". image

Also, if you add bold tags to "quite", you'll notice two more issues:

  1. bold is not compatible with italic.
  2. the tags trigger delays (more obvious with two tags). ezgif com-resize
blurymind commented 4 years ago

The wait command is supposed to trigger a delay. Can you share the project again please :)

On Sat, Apr 4, 2020, 10:58 PM PascalLadalle notifications@github.com wrote:

In the Dialogue tree example, when talking to the ant, the pause should be before the "I" is written, but it pauses after the "I". [image: image] https://user-images.githubusercontent.com/25978830/78462057-e117df00-76ce-11ea-86c4-2c232c8d90de.png

Also, if you add bold tags to "quite", you'll notice two more issues:

  1. bold is not compatible with italic.
  2. the tags trigger delays (more obvious with two tags). [image: ezgif com-resize] https://user-images.githubusercontent.com/25978830/78462102-3227d300-76cf-11ea-9167-31fd2b0bf572.gif

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/4ian/GDevelop/issues/1622, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVPXV6H2Z4KHVMT3KELRK6UP7ANCNFSM4L7H7KOQ .

PascalLadalle commented 4 years ago

The wait command triggers a delay, but not at the expected time. The pause occurs after the "I" is displayed, not before as it should. And format tags shouldn't trigger delays, I assume. Here's the project: Dialogue tree.zip

blurymind commented 4 years ago

The problem with the tags is that they are seen by the scrolling logic as characters to increment.So while you are not seeing them rendered, they are actually being included in the scrolling.

I will try to fix that when we have a text clipping function in the bbcode extension.

blurymind commented 4 years ago

The wait command being called before the I - it is strange, but I cant reproduce that issue with the project you attached at all.Are you testing with the latest gdevelop? Its possible that I fixed that already, but you are on an older version

blurymind commented 4 years ago

The bold and italic tags combination issue is a problem in pixi-multistyled-text. Please raise an issue about it here: https://github.com/tleunen/pixi-multistyle-text

blurymind commented 4 years ago

the tags slowing down scrolling issue is again something that needs to be tackled in the bbcode extension, not this. The bbcode extension needs to be able to handle clipping text to fix this cleanly. The dialogue tree extension doesnt care if we are giving to its scroller function bbcode or normal text, so its not very smart at how it increments it.

I described that in your other issue post about the dialogue tree, where you are actually talking about bbcode extension issues https://github.com/4ian/GDevelop/issues/1615#issuecomment-609101037

PascalLadalle commented 4 years ago

That's strange indeed. I experience the issue as well on the online editor: https://editor.gdevelop-app.com/?project=example://dialogue-tree-with-yarn It displays the 'I' and then makes a one second pause. I'm using beta 89.

The wait command being called before the I - it is strange, but I cant reproduce that issue with the project you attached at all.Are you testing with the latest gdevelop? Its possible that I fixed that already, but you are on an older version