4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.
https://gdevelop.io
Other
10.82k stars 848 forks source link

Javascript events autocomplete is broken #2204

Closed arthuro555 closed 3 years ago

arthuro555 commented 3 years ago

Describe the bug

Since the conversion to TS, Monaco doesn't recognize any GDJS api: image image

To Reproduce

Steps to reproduce the behavior:

  1. Go on any project
  2. Add a javascript event
  3. Type some gdjs APIs, and notice how there is no autocomplete and hovering over the variable says the type is any

Other details

4ian commented 3 years ago

Ah good catch! I think is simply forgot to change the part scanning files to search for .ts extensions

El mar., 12 de enero de 2021 11:47, Arthur Pacaud notifications@github.com escribió:

Describe the bug

Since the conversion to TS, Monaco doesn't recognize any GDJS api: [image: image] https://user-images.githubusercontent.com/19349038/104304326-887e3980-54cb-11eb-9fb4-1e7948d9dfd3.png [image: image] https://user-images.githubusercontent.com/19349038/104304361-9338ce80-54cb-11eb-8d06-dcc40cf0eb71.png To Reproduce

Steps to reproduce the behavior:

  1. Go on any project
  2. Add a javascript event
  3. Type some gdjs APIs, and notice how there is no autocomplete and hovering over the variable says the type is any

Other details

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/4ian/GDevelop/issues/2204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJYRARC5ZUARFPA3Y7XSQLSZQSEVANCNFSM4V7AHYKQ .

4ian commented 3 years ago

Actually the fix was more complex. Fixed in 9bcac613ed6cc11555dcd14bb58d08cb4790c1e7