4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.
https://gdevelop.io
Other
10.94k stars 856 forks source link

OR not selecting all object's instances if the true subcondition is not related to the object #241

Closed victorlevasseur closed 4 years ago

victorlevasseur commented 8 years ago

As said in http://forum.compilgames.net/viewtopic.php?f=20&t=7449, the OR condition has some defects.

Consider an event with an OR condition with one of its subcondition related to an object and another not. If the event is executed because of the second one (and the first one is false for all instances of the object), none of the object instances are selected and the actions related to this object will not act on any of the instances.

This should not be the case : as the event is executed because of the second condition, the list of object's instance should not be restricted and the action should act an all instances.

I attached an example : In the "ORCondition" scene, if the variable everything is = 1, all instance of TextObject should be set to "TRUE" but its not the case.

AdvancedConditionsBugs.gdg.zip

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29940233-or-not-selecting-all-object-s-instances-if-the-true-subcondition-is-not-related-to-the-object?utm_campaign=plugin&utm_content=tracker%2F3677421&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F3677421&utm_medium=issues&utm_source=github).
victorlevasseur commented 8 years ago

@4ian Bump

4ian commented 8 years ago

I've not the time to look at it now - working on another feature right now. Code generation would need a bit of clean up to properly handle all case and being simpler at the same time.