Closed D8H closed 3 years ago
Wonderful demo. Nice work ๐
On Mon, 19 Apr 2021, 19:09 D8H, @.***> wrote:
Hi!
I'd like to submit a new example to be added to GDevelop. Here is the link to
-
download it: https://www.dropbox.com/s/pudd3md7xojbyu6/BimBam.zip?dl=1
play it: https://games.gdevelop-app.com/game-fe7d476d-d9bf-411e-bf3c-fd055cd2e9a5/index.html
watch it: https://user-images.githubusercontent.com/2611977/115282856-f7ae9e00-a14a-11eb-90d2-410e824fdf6c.mp4
I confirm that any assets can be used freely by anybody, including for commercial usage.
โ You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/4ian/GDevelop/issues/2566, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVJYR4YB74HE6X6WIXDTJRWV5ANCNFSM43GLPOMQ .
Hi, I just reviewed the project and it was fun and I really loved the colours!
Some problems that I found:
There is an unused object called Mark. I think it is for some back-end stuff and not a visual object. I might be wrong. Anyway, maybe adding a comment explaining what that object does might help
I found that there is a lack of comments. Especially in the extensions. There are some complex extension and some that also use JavaScript. So, adding some comments explaining it might help
A small thing, but the readme.md has only one sentence in it. If it is not useful, maybe remove or add some extra info, But, as it is an example, it might not be important.
:)
The extensions create new variables, the rules for the variables scoped in an extension is to prefix it with underscore. Like a private variable in coding languages. Here the best pratices to follow for the extensions.
Thanks for the reviews :smile: I updated the file.
* There is a unusual bug that I found that makes the balls fall even if there are no pairs near. It happened on both the web build and also in the editor. here is an video showing it:
In the video it looks like the bubble snap over another bubble, but I couldn't reproduce it so far. There was also a rare bug where the bubbles snap on the screen edge because the grid size is 32 pixel and the collision mask size is 30. I put a bigger margin.
* There is an unused object called **Mark**. I think it is for some back-end stuff and not a visual object. I might be wrong. Anyway, maybe adding a comment explaining what that object does might help
I moved the comment nearer the Mark creation.
* I found that there is a lack of comments. Especially in the extensions. There are some complex extension and some that also use JavaScript. So, adding some comments explaining it might help
I added some. Tell me if one could be needed somewhere.
* A small thing, but the readme.md has only one sentence in it. If it is not useful, maybe remove or add some extra info, But, as it is an example, it might not be important.
The readme for examples is actually a short description that is displayed in the examples list.
The extensions create new variables, the rules for the variables scoped in an extension is to prefix it with underscore. Like a private variable in coding languages.
I added the double underscore. I find it more readable with a prefix in lower case rather than camel case because the important part of the name stands out more.
Hi, I just reviewed it and the documentation is better.
But, I still found that some portions are still not documented. Just having a small comment briefly going though what a external event/function does, is more than enough. people might get confused at first seeing all those events. So, just telling a brief description might help. Like this part, it might be confusing at first
:)
Thanks a lot for the tests and reviews Midhil, I rewrote the snap action to use an hexagonal grid. I think this should solve the bug you found. I made a new build: https://games.gdevelop-app.com/game-8ef7c8a1-cdc0-418a-a385-84620394db70/index.html
I also updated the extensions reviewed by Florian inside the project.
Hi, I just reviewed the project
:)
Sorry, I forgot about this. I upload a new version. I also fix an issue with the keyboard/mouse controls switching and add comments here and there.
Awesome demo :) I'll add it.
Added! ๐ Thanks @D8H and @Bouh, @Midhil457 for the review!
Hi!
I'd like to submit a new example to be added to GDevelop. Here is the link to
watch it: https://user-images.githubusercontent.com/2611977/115282856-f7ae9e00-a14a-11eb-90d2-410e824fdf6c.mp4
I confirm that any assets can be used freely by anybody, including for commercial usage.
It uses custom extensions