4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.
https://gdevelop.io
Other
10.83k stars 849 forks source link

New example: City Builder #2638

Closed D8H closed 3 years ago

D8H commented 3 years ago

Hi!

I'd like to submit a new example to be added to GDevelop. Here is the link to

I confirm that any assets can be used freely by anybody, including for commercial usage.

It shows how to evaluate distance by roads to define rules for city builders.

This example use these extensions:

CityBuilder

Midhil457 commented 3 years ago

Hi, I reviewed the project and it was great and it works great.

I did found some problems,

City3

:)

D8H commented 3 years ago

Thanks for the review. I did the changes and did a pass on the typos. Is it the part on the city evaluation that needs more explanations? (It's fresh in my mind so I may not see what could be hard to understand, but there is already long comments)

Midhil457 commented 3 years ago

I had a hard time figuring out how links work in the game/extension or how exactly links get to the neighbours that is being searched. When a condition checks for at most 12 links, it doesn't explain how that number is calculated/checked. And also the cost system too. You could say, I didn't understand how the whole link objects extension works :sweat_smile:

:)

D8H commented 3 years ago

I see, it's hard to understand graphs on the fly if you have never used it before. I will prepare a wiki page for this extensions with diagrams. Edit : http://wiki.compilgames.net/doku.php/gdevelop5/all-features/extensions/linked-objects-tools

Midhil457 commented 3 years ago

Hi, I reviewed the project and I wasn't able to find any issues. I do have some suggestions

:)

D8H commented 3 years ago
* Using a single object with animations representing the Palette Items instead of multiple objects added to a group. But, I wasn't able to fully making it work while testing. So, I am not sure if it is possible

It would need more events and be less intuitive in the instances editor. I don't mind having a lot of objects if it makes the events easier to understand.

* Also, as you have finished the wiki page, maybe you could include the link to the wiki so that people can learn how the linking system works. It could be helpful for someone who found it from the example list

Yes, I did it yesterday silently.

Midhil457 commented 3 years ago

I wasn't able to find any comments that showed the wiki page's link. Did I miss it?

D8H commented 3 years ago

I thought you were talking of this: Help

It's true that's not the 1st thing that's used when reading a project. I added a note before the link action.

Midhil457 commented 3 years ago

That's great! But, I did find it hard to find the comment where you have added it. It would have been more visible if you added it in a comment with more visible colours (something like green) As this example is centred around linking. It would make sense to add it at the top, but the current place is still fine. Also, it is "double" not "

Other than that, I didn’t find any other issues

:)

Midhil457 commented 3 years ago

Hi, If you are still interested in adding it to the library, you may open a issue in the new repo

:)

D8H commented 3 years ago

Right, thanks you, I opened this: https://github.com/GDevelopApp/GDevelop-examples/issues/69