Improve readability of the "+" event menu

[tristanbob]

Description

The "+" (plus) menu lets users insert special event types.

There are a couple of entries with ambiguous names:

• "Group" (could be confused with object groups)
• "Link" (it is not obvious what is being linked)

There are two redundant entries that have dedicated buttons a few pixels to the left:

• "Standard event"
• "Comment"

Solution suggested

Provide additional wording on ambiguous types:

• "Group" => "Event group"
• "Link" => "Link external event"

Remove redundant entries:

• "Standard event"
• "Comment"

[Bouh]

I agree with renaming, but I would keep the complete list. It would be necessary to rewrite pages on the wiki. Still, it's nice to have everything on one list. Personally, I never use the dedicated buttons because they are not different enough for me to recognize them.

Btw these changes have to be made on the context menu of an event.

[Silver-Streak]

Yep, I would also agree with the renaming, but also agree with Bouh that all items should be kept, since it's the same menu that you get when you right-click on "add a new event", you wouldn't want to cull anything from the list.

[tristanbob]

Thanks for the input, guys. I am fine with leaving all existing event types and just renaming the ones I listed.

[Midhil457]

I would like to dip my feet into this and this issue seems perfect. But, I have fallen into a rabbit hole of all the files, I can't find where this menu template is. Can someone just guide me to it? Thank you

[4ian]

The menu is autogenerated from the name of the events. Names are defined when declaring the events here: https://github.com/4ian/GDevelop/blob/965ec330cfb329a60dc1ccc0958b63ded3447a18/Core/GDCore/Extensions/Builtin/CommonInstructionsExtension.cpp#L86 and here: https://github.com/4ian/GDevelop/blob/965ec330cfb329a60dc1ccc0958b63ded3447a18/Core/GDCore/Extensions/Builtin/CommonInstructionsExtension.cpp#L129

If you want to see your changes, because it's in C++, you need to compile GDevelop.js by following this README: https://github.com/4ian/GDevelop/tree/master/GDevelop.js

[Midhil457]

Thank you! How can the order of the actions in the drop down be changed? The order of the actions doesn't have any relation with how it is in the file. It would make sense to have the most used on top than at the bottom

[tristanbob]

I think this is complete, based on @Midhil457 pull-request being merged.

[4ian]

I think this is good now yeah, thanks @Midhil457!

How can the order of the actions in the drop down be changed? The order of the actions doesn't have any relation with how it is in the file. It would make sense to have the most used on top than at the bottom

It's indeed arbitrary (according to how it's stored in memory or declared in the C++ I guess). You could do some sorting in the menu directly: https://github.com/4ian/GDevelop/blob/d6d4569dbf8a2acc04f36fdea1dc5adea36d3f08/newIDE/app/src/EventsSheet/Toolbar.js#L57-L66

If you want to do something it could be there (sort them, add a divider between some, make some categories?).