Set default background color based on UI theme

4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.

https://gdevelop.io

Other

11.13k stars 862 forks source link

Set default background color based on UI theme #5190

Open tristanbob opened 1 year ago

tristanbob commented 1 year ago

Description

The default background color is a very bright grey. When using a dark-mode theme, this bright background is a jarring experience since it takes up a majority of the scene editor.

Solution suggested

Describe the solution

Set default background color based on UI theme (For example, dark themes get a dark grey background, light themes get a light grey background)

AlexandreSi commented 1 year ago

I think I have seen somewhere someone asking for this color to be a preference. I had in mind that we could implement something like:

Each time you change the color of a scene's background, the editor stores in your preferences this color.
When creating a new scene, it will use this stored color.

That's not what you're asking but those two strategies conflict. What do you think?

tristanbob commented 1 year ago

I think I have seen somewhere someone asking for this color to be a preference. I had in mind that we could implement something like:

Each time you change the color of a scene's background, the editor stores in your preferences this color.

When creating a new scene, it will use this stored color.

That's not what you're asking but those two strategies conflict. What do you think?

Your idea would be a small improvement. In my case, I would change the background color to a dark gray and that would become the new default. But I'm not sure it is the best design, because people might be confused why their default background color changes.

I still think moving the background color inside the theme is the best option since it picks good default color that matches your theme.

My second choice would be to have a new preference to set the starting background color, but to me, background color feels much more like a theme-related decision.

Silver-Streak commented 1 year ago

Isn't the background color technically part of the game scene and not the IDE? I'm not sure it should be related to the IDE theme.

A way to choose the scene background color (and a default) may be best, though.

tristanbob commented 1 year ago

Figma does what I describe:

"When you create new files, Figma sets the background color to light or dark color depending on your current theme. While in light mode, newly created files default to a light-gray background color #F5F5F5. While in dark mode, they’ll default to an off-black color #1E1E1E."

https://help.figma.com/hc/en-us/articles/5576781786647-Change-themes-in-Figma

Silver-Streak commented 1 year ago

Figma does what I describe:

"When you create new files, Figma sets the background color to light or dark color depending on your current theme. While in light mode, newly created files default to a light-gray background color #F5F5F5. While in dark mode, they’ll default to an off-black color #1E1E1E."

https://help.figma.com/hc/en-us/articles/5576781786647-Change-themes-in-Figma

Interesting, I would think you wouldn't want it to change if it impacts the actual scene, but if there's precedent for it that makes sense.