Add @pixi/graphics-extras new shapes to Shape Painter objects

4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.

https://gdevelop.io

Other

10.54k stars 842 forks source link

Add @pixi/graphics-extras new shapes to Shape Painter objects #5741

Closed AlexandreSi closed 10 months ago

AlexandreSi commented 12 months ago

Description

With the upgrade to Pixi 7, @pixi/graphics-extras has been upgraded from 6.0.0 to 7.3.1. With this upgrade come 3 new shapes:

[x] Torus (done by #5981)
[x] Rectangle with chamfers (done by #5817)
[x] Regular polygons (done by #5836)

Bonus:

Fillet rectangle (rounded rectangle that supports negative rounded corners)

Solution suggested

Add the 3 missing actions for the 3 shapes mentioned above. Regarding the bonus shape, it should be done in a different Pull Request since the work is a bit different (adapt the rounded rectangle action runtime code).

Alternatives considered

Not doing it.

trp02 commented 10 months ago

Torus task should be good to mark as complete. Don't want anyone working on an implemented shape

4ian commented 10 months ago

Closing as complete 🙌

trp02 commented 8 months ago

Hello. Wanted to revisit and try to implement the bonus shape. Just to make sure were you thinking to rewrite the existing rounded rectangle code using the drawFilletRect PixiJS function?

AlexandreSi commented 8 months ago

Hello @trp02, Looking into it, it looks like drawing a rounded rectangle with the currently used method drawRoundedRect is using a different strategy than the new method drawFilletRect. I think the best to do is to make some tests:

create a new action "DrawRoundedRectangle2" that uses drawFilletRect
in a project, use both actions with the same parameters and see if there are any difference (ideally, you can use sliders to make those parameters easy to change in-game)

Then we can make a decision about backporting drawFilletRect in the action "DrawRoundedRectangle".