search

4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.
https://gdevelop.io
Other
9.28k stars 791 forks source link

Highlighting instance rectangle of deleted object does not disappear #6067

Open f0nar opened 9 months ago

f0nar commented 9 months ago

Is there an existing issue for this?

Describe the bug

If instance of object that you are going to delete is under the mouse cursor after deleting dialogs the highlighting instance rectangle is present until you hover smth else

record

Steps to reproduce

  1. Create object (was tested on tilemap, text, spine)
  2. Create its instance on scene
  3. Scale and place instance to make mouse hover it after deleting dialogs
  4. Right click on appropriate object in object list
  5. Select delete
  6. Yes to everything

GDevelop platform

Desktop

GDevelop version

5.3.183

Platform info

OS macOS Venture 13.5.2

Additional context

No response

ClementPasteau commented 9 months ago

Thanks for the issue and for the video 👍

I can indeed reproduce the problem. Have you seen any crashes following this situation? It feels to me as if it's only a temporary rendering issue but I may be wrong.

f0nar commented 9 months ago

HighlightedInstance caches instance and continue to call render with it. Nothing is crashed with objects I tested it on due to simple implementation of getWidth/Height/Depth but if one of these methods try to work with _associatedObjectConfiguration then it will throw error (It was my case with spine but I fixed that).

ClementPasteau commented 9 months ago

Definitely deserves taking a look then, thanks for the details