search

4ian / GDevelop

:video_game: Open-source, cross-platform game engine designed to be used by everyone.
https://gdevelop.io
Other
6.4k stars 717 forks source link

upgrade bondage to the yarn 2 spec - closes 6451 #6466

Open blurymind opened 2 months ago

blurymind commented 2 months ago

The new bondagejs appears to be imported correctly (see logging)

When trying to run my old test demo game however I get this error

image image

@4ian @Silver-Streak any idea why this is happening? Is it something to do with how the umd module is configured? This was one of the major things that the contributor did to modernize it. He migrated it from rollup/gulp to webpack https://github.com/hylyh/bondage.js/blob/master/gulpfile.js https://github.com/hylyh/bondage.js/blob/2.0/webpack.config.js

trying to address https://github.com/4ian/GDevelop/issues/6451

closes 6451 if I can ever figure out why the import no longer works in gdevelop

Silver-Streak commented 2 months ago

I'm not much help here, sadly. Without a stacktrace I can't even help research.

Bad end of line in the console makes it seem like something somewhere is not escaped properly, but I'm not sure.

I'd be looking at maybe @D8H for input if not @4ian

blurymind commented 2 months ago

guess if you run Gdevelop with the dialogue tree project - with this branch you will see the stack and it is not helpful at all.

It appears to get an exception at the second screenshot i made

blurymind commented 2 months ago

I just noticed the developer who upgraded this in a PR has a branch that is slightly ahead from the pr he made https://github.com/mnbroatch/bondage.js/commits/master/ https://www.npmjs.com/package/@mnbroatch/bondage I will try using the version from his branch instead