4ian / GDevelop

:video_game: Open-source, cross-platform game engine designed to be used by everyone.
https://gdevelop.io
Other
6k stars 704 forks source link

Adding the ability to specify Cordova and NPM plugin parameters in extension dependencies #6480

Open Jurfix opened 1 month ago

Jurfix commented 1 month ago

Description

I'm using a lot of Cordova plugins in one of my projects, now I'm trying to port them into GDevelop extensions and declare them using extension dependencies, one of these plugins is "cordova-plugin-customurlscheme", the problem is that this plugin requires a parameter to be specified , namely the scheme name, for example "--variable URL_SCHEME=mycoolapp", that is, the way I install the plugin in Cordova looks something like this: "cordova plugin add cordova-plugin-customurlscheme --variable URL_SCHEME=mycoolapp", the problem is, what if I try to add this plugin with a parameter in an extension dependency I get the error "name can only contain URL-friendly characters", I would like this not to throw an error, since many plugins require specifying a parameter and this would be useful.

Error logs: build-log.txt

EyadMahm0ud commented 2 weeks ago

There is a useful extension that requires this feature already, pending for 2 years: https://github.com/GDevelopApp/GDevelop-extensions/pull/625