search

4ian / GDevelop

🎮 Open-source, cross-platform 2D/3D/multiplayer game engine designed for everyone.
https://gdevelop.io
Other
10.82k stars 848 forks source link

newIde 1.0 is a bad default value for frame duration, also duration should be set in the animation previewer #809

Closed blurymind closed 5 years ago

blurymind commented 5 years ago

Describe the issue

Right now in the newIDE when you create a new animation, the default value for frames duration is 1.0 This results in an extremely slow default playback, which almost always the user will need to change to something like 0.02- 0.05

I suggest to change this value to 0.05 or something that is more likely to be used by default. Having a better default should help make workflow smoother - taking one step less to set up each animation in most cases

The other thing is that when you want to set the playback speed, you also need to be able to preview it. It would make much more sense if the user is able to set it in the preview animation window. So another suggestion is to add that to the animation player :) I will make a pull on that part tonight.

Just the thoughts of an ex-animator here

blurymind commented 5 years ago

I am assuming that the default is actually set here: https://github.com/4ian/GDevelop/blob/15773bca85cb6892a466b1d3f30477fd27ec6a5b/Core/GDCore/Extensions/Builtin/SpriteExtension/Direction.cpp#L18 but I am not completely sure

Lizard-13 commented 5 years ago

I think so, do you know what that means?, yes, recompile libGD.js >:)

blurymind commented 5 years ago

hehe yes. Come to think of it, the default value should be even lower!

0.05 or below

blurymind commented 5 years ago

I've started adding an input field to change the time in the preview dialog - it's much more intuitive now- but need to sort out its css

blurymind commented 5 years ago

Pull coming tonight - to address the second point in this issue :) gd-setframerateinpreview Changing the animation speed would this way take way less steps/clicks - as preview is shown upon value change and doesnt require several clicks. I also made the input field lest wasteful vertically

the current workflow to adjust animation speed is

  1. change value
  2. click to open preview
  3. close preview to go back
  4. select input again to adjust value
  5. go back to step 2 to preview the change again

With my pull, you can still do the old way, but you can also do

  1. Open preview
  2. change value there and see changes immediately inside the preview
  3. close preview to apply new value
Lizard-13 commented 5 years ago

Wonderful!

blurymind commented 5 years ago

pull here https://github.com/4ian/GDevelop/pull/811

it only addresses the animation previewer. recompiling gdevelop.js is a bigger task for me - even for something as simple as changing a default value. Might try it later on if nobody has addressed it and there is an agreement that 1.0 is a bad default that likely nobody will use

blurymind commented 5 years ago

ok this can be closed now :) @4ian thank you for changing the default value as well as reviewing the changes