search

4ib3r / StompBrokerJS

NodeJS StompBroker
MIT License
35 stars 66 forks source link

Version 1.2.0 - Added heartbeat support #10

Closed marverix closed 6 years ago

marverix commented 6 years ago
  1. Heartbeat done according to specification: https://stomp.github.io/stomp-specification-1.2.html#Heart-beating
  2. I cannot open this bitHound page, so I don't know which files are failing and why.
ypetya commented 6 years ago

There are other bithound issues: (you can check these by clicking the Details link next to the checks items on the PR!

  1. One missing semicolon problem in stompServer.
  2. TODO comments are not allowed.
  3. StompServer file is getting too long: StompServer also does a lot of things, which can be split up by separating out separate concerns. For example on my PR branch I factored out the config settings and my heart-beat implementation, which allows the file to be shorter and pass the bithound test.

The idea project files should not be part of the commit as other developers may use a different editor.

marverix commented 6 years ago

Thanks! When I click on "Details" new tab opens and... it's loading in infinity. This is why I asked for help here because I cannot open this page :disappointed:

marverix commented 6 years ago

Probably fixed all issues that you reported @ypetya :)

marverix commented 6 years ago

Nope. Not yet... still some errors in bitHound... Also I see that I broke README. Ah...

marverix commented 6 years ago

I have rebased, squashed and force pushed my fork to make it a bit tidy :)

marverix commented 6 years ago

I believe that this should do!

marverix commented 6 years ago

@4ib3r Adrian mógłbyś to sprawdzić? // Adrian could you review this?