search

4lex4 / scantailor-advanced

ScanTailor Advanced is the version that merges the features of the ScanTailor Featured and ScanTailor Enhanced versions, brings new ones and fixes.
GNU General Public License v3.0
1.15k stars 128 forks source link

Test failure when building debian package #132

Open anoteng opened 4 years ago

anoteng commented 4 years ago

Dear developers,

I am currently working on getting STA into Debian as a replacement for Scantailor which was removed when QT4 was removed. We are very near being able to upload, but I have this one issue which I would like to have fixed first. One of the tests fail:

xvfb-run --server-args="-screen 0 640x480x24" dh_auto_test
    cd obj-x86_64-linux-gnu && make -j1 test ARGS\+=-j1
make[2]: Entering directory '/builds/debian/scantailor-advanced/debian/output/scantailor-advanced-1.0.17~2019.08.16/obj-x86_64-linux-gnu'
Running tests...
/usr/bin/ctest --force-new-ctest-process -j1
Test project /builds/debian/scantailor-advanced/debian/output/scantailor-advanced-1.0.17~2019.08.16/obj-x86_64-linux-gnu
    Start 1: math_tests
1/3 Test #1: math_tests .......................   Passed    0.03 sec
    Start 2: imageproc_tests
2/3 Test #2: imageproc_tests ..................***Failed    0.31 sec
Running 85 test cases...
unknown location(0): fatal error: in "PolygonRasterizerTestSuite/test_complex_shape": memory access violation at address: 0x00000000: no mapping at fault address
/builds/debian/scantailor-advanced/debian/output/scantailor-advanced-1.0.17~2019.08.16/src/imageproc/tests/TestPolygonRasterizer.cpp(106): last checkpoint
Test is aborted
Test is aborted
Test is aborted
*** 1 failure is detected in the test module "Master Test Suite"
    Start 3: core_tests
3/3 Test #3: core_tests .......................   Passed    0.01 sec
67% tests passed, 1 tests failed out of 3
Total Test time (real) =   0.35 sec
The following tests FAILED:
      2 - imageproc_tests (Failed)
Errors while running CTest

I am guessing this is related to the fact that we are running the tests using xvfb instead of on a real screen. Any advice on this matter? Full build log here: https://salsa.debian.org/debian/scantailor-advanced/-/jobs/773112

4lex4 commented 4 years ago

The fastest way is just to disable those tests: make -j1 test ARGS+="-j1 --exclude-regex \"imageproc_.*\""

anoteng commented 4 years ago

Yeah, that works, but I'd prefer if we figured out a way to get the tests running properly.

rbrito commented 3 years ago

@anoteng, any news on scantailor-advanced on Debian? Can you upload a version, even if it is not Debian-perfect somewhere?

anoteng commented 3 years ago

@rbrito I just uploaded it built for Ubuntu Groovy here: https://launchpad.net/~andreas-noteng/+archive/ubuntu/scantailor-advanced I'll upload for some more ubuntu versions to the Launchpad PPA. My sponsor has agreed to sponsor the upload to Debian. We just have to figure out these failing hardening checks: https://salsa.debian.org/debian/scantailor-advanced/-/jobs/1459193 Hopefully it'll be uploaded to unstable in a few days.