search

4lex4 / scantailor-advanced

ScanTailor Advanced is the version that merges the features of the ScanTailor Featured and ScanTailor Enhanced versions, brings new ones and fixes.
GNU General Public License v3.0
1.18k stars 129 forks source link

icc profiles #15

Open bezverec opened 6 years ago

bezverec commented 6 years ago

Would it be possible to implement at least an option to keep icc profiles embedded in images? ScanTailor currently removes icc profiles by default with no setting regarding icc profiles, if I am not mistaken. Thanks.

ismay7 commented 6 years ago

Good point. We, too (using ST professionally at the library), would be greatly interested in having this option. Our workaround currently is to convert to sRGB beforehand and re-append it afterwards. So an integrated automatic conversion (to sRGB) would already be pleasant, too. Best regards to everyone here ;-)

4lex4 commented 6 years ago

ST doesn't remove embedded icc profiles but creates the new own output image from the source one. The internal processing algorithms have some requirements on the icc profile used. Output images can be binary, indexed, gray or rgb, depending on processing parameters.

If you use color output, what the problem to convert the ST output via an external tool like image magick or any image editor/viewer with a batch feature?

bezverec commented 6 years ago

Thanks for the response. Yes, it is unproblematic to re-attach desired icc profile using ImageMagick. Some feature to keep input icc profiles in output images (and/or more) would come in handy though, as it would save some invaluable time in our workflow. Seems to make sense in the case you just want to crop & deskew (possibly rotate & split) without any other changes to your images, so the original images can be deleted afterwards. How difficult it is to implement, I do not know, it is completely up to you of course. I appreciate your great work on ST anyway, thank you! :)

ismay7 commented 6 years ago

I guess the only slightly problematic issue here is the ST output not having a color profile attached at all, which is totally ok, as long as one is aware of that fact and knows how to re-attach the one it had at the input stage. If the input images have some certain color profile embedded, for instance a specific scanning device profile, the color accuracy within the ST output images may not be rendered correctly without re-attaching the old profile. It's not a big issue however as long as one is aware of the fact. But STA is coming along superbly, anyway. Thank you for that!

4lex4 commented 6 years ago

If you mean 16 bit color depth, to support that almost all the processing algorithms at the output stage modifying the image have to be reworked. It promises to take very much time and I think it isn't worth that.

bezverec commented 6 years ago

Our standard is 8 bit.