4lex4nder / ReshadeEffectShaderToggler-FFXIV

FFXIV specific ReshadeEffectShaderToggler configuration
MIT License
60 stars 3 forks source link

Crashes the FFXIV Dawntrail Benchmark at launch (even without the FFXIV config!). #12

Closed ipsusu closed 4 months ago

ipsusu commented 5 months ago

Hi, not sure if this should go on the main repo, as the issue persists even without the FFXIV specific config, but I thought since the crash was specific to FFXIV so I'll put it here.

Let me know if you want me to repost it to the main repo.


The addon crashes on the FFXIV Dawntrail benchmark (both the original version and the Ver 1.1) at launch. If this is not a specific error in relation to how the benchmark is structured/released, it is likely persist to the full game release at the end of this month. Which will start crashing people's games after they update, unless they delete REST entirely...

Here is my ReShade.log on a fresh install of ReShade 6.1.1, using the default settings of the benchmark (only thing I changed was Windowed -> Windowed Borderless.).

This is the log from after I had deleted the config .ini, to verify that it was not causing the crash.

14:02:11:190 [22672] | INFO  | Registering hooks for "user32.dll" ...
14:02:11:190 [22672] | INFO  | > Libraries loaded.
14:02:11:191 [22672] | INFO  | > Found 14 match(es). Installing ...
14:02:11:223 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\dinput.dll" ...
14:02:11:223 [22672] | INFO  | > Delayed.
14:02:11:223 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\d2d1.dll" ...
14:02:11:223 [22672] | INFO  | > Delayed.
14:02:11:223 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\d3d9.dll" ...
14:02:11:223 [22672] | INFO  | > Delayed.
14:02:11:224 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\d3d10.dll" ...
14:02:11:224 [22672] | INFO  | > Delayed.
14:02:11:224 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\d3d10_1.dll" ...
14:02:11:224 [22672] | INFO  | > Delayed.
14:02:11:224 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\d3d11.dll" ...
14:02:11:224 [22672] | INFO  | > Libraries loaded.
14:02:11:224 [22672] | INFO  | > Found 3 match(es). Installing ...
14:02:11:256 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\d3d12.dll" ...
14:02:11:257 [22672] | INFO  | > Delayed.
14:02:11:257 [22672] | INFO  | Registering hooks for "C:\WINDOWS\system32\dxgi.dll" ...
14:02:11:257 [22672] | INFO  | > Delayed until first call to an exported function.
14:02:11:257 [22672] | INFO  | Registering hooks for "vrclient_x64.dll" ...
14:02:11:257 [22672] | INFO  | > Delayed.
14:02:11:257 [22672] | INFO  | Initialized.
14:02:11:267 [22672] | INFO  | Redirecting RegisterClassExA(lpWndClassEx = 000000A5D394F2E0 { "FFXIVGAME", style = 0x3 }) ...
14:02:11:267 [22672] | INFO  | > Adding 'CS_OWNDC' window class style flag to "FFXIVGAME".
14:02:11:636 [05232] | INFO  | Redirecting RegisterClassW(lpWndClass = 000000A5D55FFEA0 { "ShellHandwritingWorkerWindowClass", style = 0 }) ...
14:02:11:669 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {7B7166EC-21C7-44AE-B21A-C9AE321AE369}, ppFactory = 000000A5D394E8B8) ...
14:02:11:670 [22672] | INFO  | Installing export hooks for "C:\WINDOWS\system32\dxgi.dll" ...
14:02:11:670 [22672] | INFO  | > Found 5 match(es). Installing ...
14:02:11:680 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {7B7166EC-21C7-44AE-B21A-C9AE321AE369}, ppFactory = 000000A5D394E698) ...
14:02:11:680 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {7B7166EC-21C7-44AE-B21A-C9AE321AE369}, ppFactory = 000000A5D394E718) ...
14:02:11:683 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {7B7166EC-21C7-44AE-B21A-C9AE321AE369}, ppFactory = 000000A5D394E7B8) ...
14:02:11:684 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {7B7166EC-21C7-44AE-B21A-C9AE321AE369}, ppFactory = 0000028390B59AE8) ...
14:02:11:684 [22672] | INFO  | Redirecting D3D11CreateDevice(pAdapter = 00000283901D2200, DriverType = 0, Software = 0000000000000000, Flags = 0x80, pFeatureLevels = 000000A5D394E86C, FeatureLevels = 1, SDKVersion = 7, ppDevice = 0000028390B59AF8, pFeatureLevel = 0000028390B59AE0, ppImmediateContext = 0000028390B59B00) ...
14:02:11:684 [22672] | INFO  | > Passing on to D3D11CreateDeviceAndSwapChain:
14:02:11:684 [22672] | INFO  | Redirecting D3D11CreateDeviceAndSwapChain(pAdapter = 00000283901D2200, DriverType = 0, Software = 0000000000000000, Flags = 0x80, pFeatureLevels = 000000A5D394E86C, FeatureLevels = 1, SDKVersion = 7, pSwapChainDesc = 0000000000000000, ppSwapChain = 0000000000000000, ppDevice = 0000028390B59AF8, pFeatureLevel = 0000028390B59AE0, ppImmediateContext = 0000028390B59B00) ...
14:02:11:782 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {770AAE78-F26F-4DBA-A829-253C83D1B387}, ppFactory = 000000A5D394B0B8) ...
14:02:11:835 [22672] | INFO  | Using feature level 0xb000.
14:02:11:835 [22672] | INFO  | Searching for add-ons (*.addon, *.addon64) in "C:\Users\ipsum\Documents\Benchmark\DD\game" ...
14:02:11:836 [22672] | INFO  | Loading add-on from "C:\Users\ipsum\Documents\Benchmark\DD\game\ReshadeEffectShaderToggler.addon64" ...
14:02:11:839 [22672] | INFO  | Registered add-on "Reshade Effect Shader Toggler" v1.3.15.592 using ReShade API version 8.
14:02:11:839 [22672] | INFO  | [Reshade Effect Shader Toggler] Loading config file from "C:\Users\ipsum\Documents\Benchmark\DD\game\ReshadeEffectShaderToggler.ini"
14:02:11:839 [22672] | INFO  | [Reshade Effect Shader Toggler] Could not find config file at "C:\Users\ipsum\Documents\Benchmark\DD\game\ReshadeEffectShaderToggler.ini"
14:02:11:839 [22672] | INFO  | [Reshade Effect Shader Toggler] No resource shim initialized
14:02:11:840 [22672] | INFO  | Redirecting IDXGIFactory::CreateSwapChain(this = 00000283901D6670, pDevice = 00000283A3DCC378, pDesc = 000000A5D394E8A0, ppSwapChain = 000000A5D394E870) ...
14:02:11:840 [22672] | INFO  | > Dumping swap chain description:
14:02:11:840 [22672] | INFO  |   +-----------------------------------------+-----------------------------------------+
14:02:11:840 [22672] | INFO  |   | Parameter                               | Value                                   |
14:02:11:840 [22672] | INFO  |   +-----------------------------------------+-----------------------------------------+
14:02:11:840 [22672] | INFO  |   | Width                                   | 2552                                    |
14:02:11:841 [22672] | INFO  |   | Height                                  | 1409                                    |
14:02:11:841 [22672] | INFO  |   | RefreshRate                             | 60                  1                   |
14:02:11:841 [22672] | INFO  |   | Format                                  | DXGI_FORMAT_R8G8B8A8_UNORM              |
14:02:11:841 [22672] | INFO  |   | ScanlineOrdering                        | 1                                       |
14:02:11:841 [22672] | INFO  |   | Scaling                                 | 0                                       |
14:02:11:841 [22672] | INFO  |   | SampleCount                             | 1                                       |
14:02:11:841 [22672] | INFO  |   | SampleQuality                           | 0                                       |
14:02:11:841 [22672] | INFO  |   | BufferUsage                             | 0x20                                    |
14:02:11:841 [22672] | INFO  |   | BufferCount                             | 2                                       |
14:02:11:841 [22672] | INFO  |   | OutputWindow                            | 00000000000B0FC4                        |
14:02:11:841 [22672] | INFO  |   | Windowed                                | TRUE                                    |
14:02:11:842 [22672] | INFO  |   | SwapEffect                              | 0                                       |
14:02:11:842 [22672] | INFO  |   | Flags                                   | 0x2                                     |
14:02:11:842 [22672] | INFO  |   +-----------------------------------------+-----------------------------------------+
14:02:11:847 [22672] | INFO  | Running on NVIDIA GeForce RTX 3080 Driver 555.99.
14:02:11:953 [22672] | INFO  | Recreated runtime environment on runtime 00000283A3EA0B70 ("C:\Users\ipsum\Documents\Benchmark\DD\game\ReShade.ini").
14:02:11:953 [22672] | INFO  | Redirecting IDXGISwapChain::SetFullscreenState(this = 00000283A3420890, Fullscreen = FALSE, pTarget = 0000000000000000) ...
14:02:12:593 [22672] | INFO  | Installing delayed hooks for "C:\WINDOWS\system32\d3d12.dll" (Just loaded via LoadLibrary("C:\Windows\System32\d3d12.dll")) ...
14:02:12:596 [22672] | INFO  | > Found 8 match(es). Installing ...
14:02:14:732 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {770AAE78-F26F-4DBA-A829-253C83D1B387}, ppFactory = 000000A5D394D9A8) ...
14:02:14:816 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {770AAE78-F26F-4DBA-A829-253C83D1B387}, ppFactory = 000000A5D394D4B8) ...
14:02:14:816 [22672] | INFO  | Redirecting D3D12CreateDevice(pAdapter = 00000283A3E69230, MinimumFeatureLevel = 0xb000, riid = {189819F1-1DB6-4B57-BE54-1821339B85F7}, ppDevice = 000000A5D394D4C8) ...
14:02:14:818 [22672] | INFO  | Redirecting CreateDXGIFactory2(Flags = 0x80000000, riid = {1BC6EA02-EF36-464F-BF0C-21CA39E5168A}, ppFactory = 000000A5D394CD78) ...
14:02:14:867 [22672] | INFO  | Redirecting CreateDXGIFactory1(riid = {770AAE78-F26F-4DBA-A829-253C83D1B387}, ppFactory = 000000A5D394B1C8) ...

Let me know if you need any further information from me.

PC Specs: CPU: 5800X GPU: 3080 FE MEM: 32GB 3600MHz DDR4 OS: Windows 11 23H2

NotNite commented 5 months ago

Seems to work for me (on an RX 6800 XT).

ipsusu commented 5 months ago

Seems to work for me (on an RX 6800 XT).

Yeah, maybe it's an Nvidia thing, or just a weird thing on my PC? If it's not a widespread issue, that's good at least LOL.

I tested it with FSR enabled, disabled, DLSS enabled. Fullscreen, Windowed and Windowed Borderless and I'm still getting the same issue.

ipsusu commented 5 months ago

Had someone else try it out, and they seem to get the crash on an NVIDIA card also: https://twitter.com/SnapsCube/status/1799483384437289019

4lex4nder commented 5 months ago

Known issue, Dawntrail changes a lot of their rendering pipeline. So most mods will get rekt. I did some preliminary work reverse engineering Dawntrail stuff (see ffxiv70 branch of REST: https://github.com/4lex4nder/ReshadeEffectShaderToggler/tree/ffxiv70), but stuff will probably change some more until the final release, so I've not bothered with releasing anything until then.

ipsusu commented 5 months ago

Known issue, Dawntrail changes a lot of their rendering pipeline. So most mods will get rekt. I did some preliminary work reverse engineering Dawntrail stuff (see ffxiv70 branch of REST: https://github.com/4lex4nder/ReshadeEffectShaderToggler/tree/ffxiv70), but stuff will probably change some more until the final release, so I've not bothered with releasing anything until then.

Awesome, glad you're aware at least. Unfortunate that it's a ticking timebomb until then though. I'll do what I can to make people aware that it's a problem.

isvein commented 4 months ago

Known issue, Dawntrail changes a lot of their rendering pipeline. So most mods will get rekt. I did some preliminary work reverse engineering Dawntrail stuff (see ffxiv70 branch of REST: https://github.com/4lex4nder/ReshadeEffectShaderToggler/tree/ffxiv70), but stuff will probably change some more until the final release, so I've not bothered with releasing anything until then.

Awesome, glad you're aware at least. Unfortunate that it's a ticking timebomb until then though. I'll do what I can to make people aware that it's a problem.

Thanks to your github I was made aware of this before installing :) Glad to see 4lex4nder is aware too and will update once 7.0 is released 👍

4lex4nder commented 4 months ago

Way ahead of you, see README

isvein commented 4 months ago

Way ahead of you, see README

It was not that when I wrote that post 33min ago 😆 Thanks 😄

ipsusu commented 4 months ago

Way ahead of you, see README

Ah, is this fixed now?!

4lex4nder commented 4 months ago

Kind of. Still stuff to iron out, so read the updated README carefully (I've updated it multiple times today)

ipsusu commented 4 months ago

Haven't had any reports, so seems to be fixed. Thanks!