4lex4nder / ReshadeEffectShaderToggler-FFXIV

FFXIV specific ReshadeEffectShaderToggler configuration
MIT License
60 stars 2 forks source link

REST v1.3.19 having gamma issues again? #15

Closed ipsusu closed 1 month ago

ipsusu commented 2 months ago

Hi, I make a preset collection for ReShade.

Lots of my users have been contacting me saying the game is too dark, seemingly caused by the Glamayre_Fast_Effects.fx shader.

However, in actually troubleshooting this, they all seem to have newly installed REST, which is causing the weird interaction with the shader.

Most users can get it fixed by setting gamma to 49 or 51, but then one who was having issues with it set to 55 got it fixed by setting it back to 50?

Can find troubleshooting info in my twitter replies here (sorry, login walled I think...): https://twitter,com/ipsusu/with_replies

I have no idea what's going on, I was wondering if you could have another look at the recent changes made in v1.3.19. I'm running v1.3.18 with the older config .ini and haven't had this issue.

Emperor-Rampage commented 2 months ago

To add a piece of info here: Disabling the UI causes the darkness to disappear and the preset to display normally.

It'll flash on and off during cutscenes, becoming dark when the dialogue box is rendered.

4lex4nder commented 2 months ago

Ensure you are, in fact, using 1.3.19 (ReShade installer will install an old version), you can do that by opening ReShade's addon tab and expanding "ReshadeEffectShaderToggler". Additionally, make sure you have the latest .ini from this repository (overwrite if you must). Also check whether you have the .ini or .addon64 in some unintended subfolder

Don't have twitter, so can't really comment on that

ipsusu commented 2 months ago

To add a piece of info here: Disabling the UI causes the darkness to disappear and the preset to display normally.

It'll flash on and off during cutscenes, becoming dark when the dialogue box is rendered.

I think this is a different issue, but if its the same issue, that would be good. I'm advising everyone to update their REST anyway, I've just had people say that updating didn't work (maybe they didn't update properly?) and that the gamma change seemed to fix it.

ipsusu commented 2 months ago

Ensure you are, in fact, using 1.3.19 (ReShade installer will install an old version), you can do that by opening ReShade's addon tab and expanding "ReshadeEffectShaderToggler". Additionally, make sure you have the latest .ini from this repository (overwrite if you must). Also check whether you have the .ini or .addon64 in some unintended subfolder

Don't have twitter, so can't really comment on that

Oh, if you're saying the ReShade installer downloads an old version of REST, if they use the new .ini config from this repo with it, it might cause issues?

Why does the ReShade installer do this?!

4lex4nder commented 2 months ago

Sorry, might have said it wrong: If you try installing REST using the ReShade installer, it might be an older version. Always manually install the version outlined in the README here.

ipsusu commented 2 months ago

Oh, ok. Sorry if I got confused. From what I thought, it just pulled whatever the latest version was from the main repo at the time of the ReShade install. Is this the case?

4lex4nder commented 2 months ago

Let me double check, but from what I remember, the version ReShade pulls is hardcoded

4lex4nder commented 2 months ago

Indeed, see the manifest where it pulls it's list from: https://raw.githubusercontent.com/crosire/reshade-shaders/list/Addons.ini currently that 1.3.15

ipsusu commented 2 months ago

Oh I see... is there a reason for the download to be hardcoded on that specific release? I would have thought you would want the latest available.

It may be worth adding to README here that there may be this version mismatch, because I wouldn't have thought a freshly downloaded REST from the ReShade installer would be different from the latest from the repo that is listed on the installer. (I don't think it shows you the version number in the add-ons install step)

4lex4nder commented 2 months ago

It just takes time to catch up. There were multiple new REST builds in the last few days. But even then, I'd always explicitly use whatever the README says, since I can't guarantee even backwards compatibility. I tend to break stuff

ipsusu commented 2 months ago

I mean, surely if the download URL in the manifest was changed from https://github.com/4lex4nder/ReshadeEffectShaderToggler/releases/download/v1.3.15/release.zip to https://github.com/4lex4nder/ReshadeEffectShaderToggler/releases/latest/download/release.zip, it would prevent this desync? The manifest would then no longer need to be updated, it would just rely on the GitHub servers to pull whatever the latest release is at that point.

4lex4nder commented 2 months ago

It is what it is, I'll bring it up with crosire. Meanwhile I've updated the README

ipsusu commented 2 months ago

It is what it is, I'll bring it up with crosire. Meanwhile I've updated the README

All good! If people are coming to me with this issue, I'll let them know to update then. Thank you for your work!

Off-topic, but I'm also adding onto your REST .ini for FFXIV to include the pixel shaders for in-game transparencies, so ambient occlusion shaders can render beneath the fog and smoke, and I think even seemingly render under the anti-aliasing of the game? I have no idea what I'm doing, but the WiP version I've got seems to work well so far, however I've had some reports of some black squares glitching in some effects.

Haven't updated this yet with your changes for 1.3.19, still using 1.3.18, but see the "FOG" group here: https://gist.github.com/ipsusu/9356c4b5cf300d621694461157db4755

And here is the preset that I'm using to test it currently: https://gist.github.com/ipsusu/8dfe72f8556a94c94e8157e76370902d

It would be great if I could work with you on this, or at least to be able to ask you some questions about best processes and how I can troubleshoot the issues.

This is like actually ground-breaking stuff for ReShade presets in FFXIV and it would be amazing to have this glitch free + included with a package like GPosingway or GShade. I know the GPosingway folks are definitely interested.

Thanks for making this possible!

4lex4nder commented 2 months ago

I'll re-add the missing fog-related groups this weekend or something. Removed them temporarily to fix the basics right after the update. To answer your question: FFXIV uses an HDR pipeline before the final tone mapping, hence using a RGBA16F buffers there. Most effects do not play nice with that out of the box, which is why I had specialized effects here that I have to re-do for the update. Some may work, but you need to ensure to enable "preserve alpha" and "tone map" for that group (and make sure those .FX files from REST are deployed).

As for GShade or other stuff. I try to keep my license liberal, so people can mostly do whatever. Personally, REST was developed because GShade pissed me off, and I'm not going to support closed-source forks of any shape.

ipsusu commented 2 months ago

I'll re-add the missing fog-related groups this weekend or something. Removed them temporarily to fix the basics right after the update. To answer your question: FFXIV uses an HDR pipeline before the final tone mapping, hence using a RGBA16F buffers there. Most effects do not play nice with that out of the box, which is why I had specialized effects here that I have to re-do for the update. Some may work, but you need to ensure to enable "preserve alpha" and "tone map" for that group (and make sure those .FX files from REST are deployed).

As for GShade or other stuff. I try to keep my license liberal, so people can mostly do whatever. Personally, REST was developed because GShade pissed me off, and I'm not going to support closed-source forks of any shape.

Awesome! Great info, I'll take a look this weekend then and look into those shaders.

In the meantime: I've had to disable some of the nice effects in the test preset as the way this config works is by basically just contaminating the information seen by the shader. Sadly iMMERSE MXAO has this insane brightness flicker when looking up at the sky and Glamarye with Fake GI breaks entirely in some scenes with a black transparency as the background/sky too.

Updated my transparency groups here to be a bit more conservative (I test these all on the yellow fog, acid puddles and glowing plants of the first room in Aurum Vale) and I've swapped over to using the non-Fake GI version of Glamarye to prevent the prior mentioned issue. Also updated it with your 1.3.19 changes: https://github.com/ipsusu/IpsuShade?tab=readme-ov-file#experimental-rest-transparency-fix

I'm sure there's a better way to do this and yeah, likely it's through custom shaders. I'm just wary of any custom MXAO because the shading rate features of iMMERSE let's you really cut down on the GPU load. Other AOs are a bit too demanding.

Thanks so much for your effort!