search

4lex4nder / ReshadeEffectShaderToggler

Reshade 5+ addin to apply Reshade effects to render targets of shader groups based on a key press. It allows you to configure these groups from within the addin as well.
MIT License
110 stars 10 forks source link

Upside down in/output at specific toggle group #23

Closed Small-Ku closed 2 months ago

Small-Ku commented 1 year ago

iMMERSE launchpad debug output Can the addon deal with this like upside down the input and output of shaders?

4lex4nder commented 1 year ago

This should be fixed by setting RESHADE_DEPTH_INPUT_IS_UPSIDE_DOWN to 1, I think. REST itself does not intervene in how the game applies it's own shaders.

Small-Ku commented 1 year ago

But it only upside down inside some shaders of the game. Example

logarrhythmic commented 1 year ago

I have a similar problem with that other anime game from this developer, my RESHADE_DEPTH_INPUT_IS_UPSIDE_DOWN is set to 1 and it fixes the depth buffer for shaders, but there are a lot of shaders in the group settings that show the preview upside-down and using them will make affected shaders also flip upside down. For example, I have one pixel shader where the preview is exactly the 3D scene without the UI, but it's upside down. If I select it and set Invocation location to AFTER DRAW or ON RENDER TARGET CHANGE, the UI is perfectly excluded and right-side-up, but anything ReShade touches is flipped upside down. image There are some other pixel shaders that seem to contain most of the UI and don't flip anything. image The NPC nameplate is not excluded properly here. It would be nice to have some kind of upside-down toggle somewhere, but I don't actually know how any of this works, so maybe there's already something I could do if I knew how.

EDIT: ...upon further reflection, I might be able to just set RESHADE_DEPTH_INPUT_IS_UPSIDE_DOWN to 0 and get exactly what I need. It's weird that specific shaders flip the buffer, though, and if I don't use the shader toggler I do need to flip the depth buffer.

carycary246 commented 1 year ago

Same issue with Genshin as well. Some shaders are flipped such as this one for fog which breaks when I want to use that toggle group so I can use MXAO and RTGI without applying to the fog as otherwise they will show through. However, as you can see it is flipped so it renders upside down so we need a switch for this toggle group to flip it. upside down shader

4lex4nder commented 11 months ago

Added option to flip with 1.3.8

carycary246 commented 11 months ago

Added option to flip with 1.3.8

Thanks for adding this but running into an issue with flipping, it doesn't do the full image. I suspect it may be related to my game resolution being 2560x1440 but the addon is reporting 3840x2160 resulting in a mismatched flip.

image

4lex4nder commented 11 months ago

If you're using FSR2/DLSS with scaling factor != 1.0: Don't