Error message on install

4ndygu / civicrm_osdi

An Extension for importing from and exporting to OSDI endpoints from CiviCRM

Other

4 stars 4 forks source link

Error message on install #12

Open MegaphoneJon opened 6 years ago

MegaphoneJon commented 6 years ago

I get this:

Warning: Declaration of CRM_Osdi_Permission::check($permissions) should be compatible with CRM_Core_Permission::check($permissions, $contactId = NULL) in require_once() (line 218 of /home/jon/local/civicrm-buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Core/ClassLoader.php).

It seems like a function signature mismatch that shouldn't really affect anything, but it's quick enough to clean up, and gives reviewers confidence in the code.

4ndygu commented 6 years ago

Are you installing this on a regular Drupal instance? I don't see this when I install.

MegaphoneJon commented 6 years ago

Hmm - I wonder if the function signature changed in core? It's not impossible.

4ndygu commented 6 years ago

weird. I'll try on osdi3 tomorrow and see if it throws the error.