enable python style check via pylint

4paradigm / OpenMLDB

OpenMLDB is an open-source machine learning database that provides a feature platform computing consistent features for training and inference.

https://openmldb.ai

Apache License 2.0

1.58k stars 317 forks source link

enable python style check via pylint #315

Closed aceforeverd closed 2 years ago

aceforeverd commented 3 years ago

Expected Behavior

using Pylint for python code style check for pull requests

Current Behavior

there is pylintrc already, but no pylint workflow

Possible Solution

adding pylint check to .github/workflows/style.yml

Notice

there seems no reviewdog-pylint available, it's fine to run pylint directly
the current code may generate many errors after enabling Pylint, you may skip specifying the directory for Pylint check in this issue (PRs to fix those error are also welcome)

Nagateja22 commented 3 years ago

I am trying to raise a PR with pylint changes its says permission denied could someone give me access. remote: Permission to 4paradigm/OpenMLDB.git denied to Nagateja22. fatal: unable to access 'https://github.com/4paradigm/OpenMLDB.git/': The requested URL returned error: 403

aceforeverd commented 3 years ago

I am trying to raise a PR with pylint changes its says permission denied could someone give me access. remote: Permission to 4paradigm/OpenMLDB.git denied to Nagateja22. fatal: unable to access 'https://github.com/4paradigm/OpenMLDB.git/': The requested URL returned error: 403

Hi @Nagateja22 , for opensource project , you can fork the repository to your own space first, commit the change and create a pull request. Checkout links below for more information:

Also, if you can, checkout our commit style guide:

https://github.com/4paradigm/rfcs/blob/main/style-guide/commit-convention.md
sign your commit with gpg: https://github.com/4paradigm/OpenMLDB/discussions/289

mangoGoForward commented 2 years ago

[WeOpen Star]I would like to help

mangoGoForward commented 2 years ago

Hi @aceforeverd Should we separate two PRs to support pylint check and fix pylint errors?

aceforeverd commented 2 years ago

Hi @aceforeverd Should we separate two PRs to support pylint check and fix pylint errors?

I recommend separate it. There suppose to be many errors from pylint.

mangoGoForward commented 2 years ago

I recommend separate it. There suppose to be many errors from pylint.

Yes, I noticed. Please let me try~