4paradigm / OpenMLDB

OpenMLDB is an open-source machine learning database that provides a feature platform computing consistent features for training and inference.
https://openmldb.ai
Apache License 2.0
1.59k stars 318 forks source link

TaskManagerConfig set default zookeeper.cluster prop typo #3783

Open yangwucheng opened 8 months ago

yangwucheng commented 8 months ago

Bug Description java/openmldb-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/config/TaskManagerConfig.java line 303 set zookeeper.cluster prop typo

        if (props.getProperty("zookeeper.cluster") == null) {
            props.setProperty("", "");
        }

Expected Behavior props.setProperty("zookeeper.cluster", "")

Relation Case

Steps to Reproduce

aceforeverd commented 8 months ago

@yangwucheng does that cause any problem ?

yangwucheng commented 8 months ago

@yangwucheng does that cause any problem ?

暂时没有发现

vagetablechicken commented 8 months ago

You mean it should be refactored? I think it should be refactor, it's not a bug, just redundant code?