search

4paradigm / OpenMLDB

OpenMLDB is an open-source machine learning database that provides a feature platform computing consistent features for training and inference.
https://openmldb.ai
Apache License 2.0
1.59k stars 321 forks source link

ci: update create-pull-request action to v6 in udf-doc-gen workflow & rm deprecated file sync #3964

Closed Jayaprakash0511 closed 3 months ago

Jayaprakash0511 commented 4 months ago

udf doc gen fail issue#3903 (bug). Updated the create-pull-request (.github/worflows/udf-doc.yml) to v6 which is currently using v4 causing deprecated issues.

github-actions[bot] commented 4 months ago

SDK Test Report

102 files  + 2  102 suites  +2   2m 20s :stopwatch: +13s 359 tests +41  345 :white_check_mark: +37  14 :zzz: +4  0 :x: ±0  487 runs  +41  473 :white_check_mark: +37  14 :zzz: +4  0 :x: ±0 

Results for commit 6f403c07. ± Comparison against base commit 4138c1b6.

This pull request removes 48 and adds 68 tests. Note that renamed tests count towards both. ``` PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1 PARTITION BY t1.col2 ORDER BY t1.col1 ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW ) limit 10;](1) ) limit 10;](2) ) limit 10;](3) FROM db1.t1 FROM t1 WINDOW w1 AS ( last join db2.t2 order by db2.t2.col1 … ``` ``` com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[, SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1 FROM db1.t1 last join db2.t2 order by db2.t2.col1 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0 WINDOW w1 AS ( PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1 ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW ) limit 10;](2) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1, SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1 FROM t1 last join db2.t2 order by db2.t2.col1 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0 WINDOW w1 AS ( PARTITION BY t1.col2 ORDER BY t1.col1 ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW ) limit 10;](1) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null, SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1 FROM db1.t1 last join db2.t2 order by db2.t2.col1 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0 WINDOW w1 AS ( PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1 ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW ) limit 10;](3) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1 FROM t1 last join db2.t2 order by db2.t2.col1 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0; , SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1 FROM t1 last join db2.t2 order by db2.t2.col1 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0; , SQL parse error: Column Not found: db1.t2.str1](2) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1 FROM t1 last join db2.t2 order by db2.t2.col1 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0; , SQL parse error: Column Not found: .t2.col1](3) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1 FROM t1 last join db2.t2 order by db2.t2.col1 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0; , SQL parse error: Column Not found: .t2.str1](1) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1 FROM t1 last join db2.t2 order by db2.t2.col1 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0; , SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5) com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1 FROM t1 last join t2 order by t2.col1 on t1.col1 = t2.col1 and t1.col2 = t2.col0 WINDOW w1 AS ( PARTITION BY t1.col2 ORDER BY t1.col1 ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW ) limit 10;](1) com._4paradigm.openmldb.jdbc.SQLRouterSmokeTest ‑ testInsertMeta[com._4paradigm.openmldb.sdk.impl.SqlClusterExecutor@5274830e](2) … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Linux Test Report

    60 files  ±0     253 suites  ±0   1h 56m 49s :stopwatch: - 4m 14s 13 605 tests ±0  13 598 :white_check_mark: ±0  7 :zzz: ±0  0 :x: ±0  19 317 runs  ±0  19 310 :white_check_mark: ±0  7 :zzz: ±0  0 :x: ±0 

Results for commit 6f403c07. ± Comparison against base commit 4138c1b6.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.79%. Comparing base (4138c1b) to head (6f403c0). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3964 +/- ## ============================================ - Coverage 77.90% 74.79% -3.12% - Complexity 0 711 +711 ============================================ Files 566 762 +196 Lines 125667 137454 +11787 Branches 0 2072 +2072 ============================================ + Hits 97907 102811 +4904 - Misses 27760 34340 +6580 - Partials 0 303 +303 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aceforeverd commented 3 months ago

@Jayaprakash0511 Hi, thanks for your interests.

However, the workflow fails actually because the file docs/en/reference/sql/udfs_8h.md does not exists any more.

you should at least update the configuration in both:

Jayaprakash0511 commented 3 months ago

@Jayaprakash0511 Hi, thanks for your interests.

However, the workflow fails actually because the file docs/en/reference/sql/udfs_8h.md does not exists any more.

you should at least update the configuration in both:

Thank you for your response! Seeing the errors , I thought there were only deprecated issues related to Buffer(), hence changed the pull request version to the latest. Now i have removed references to docs/en/reference/sql/udfs_8h.md as the file no longer exists.

github-actions[bot] commented 3 months ago

HybridSE Mac Test Report

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 6f403c07.

github-actions[bot] commented 3 months ago

HybridSE Linux Test Report

20 433 tests   20 431 :white_check_mark:  6m 25s :stopwatch:    262 suites       2 :zzz:     69 files         0 :x:

Results for commit 6f403c07.