search

4pr0n / ripme

Downloads albums in bulk
MIT License
912 stars 205 forks source link

Tagged tumblr videos aren't found via /video api request #114

Open ripreports opened 9 years ago

ripreports commented 9 years ago

When the ripme application does an api request for video with a tag no videos will be returned even if there are tagged videos.

The only way to get the tagged videos is to request a full listing of videos without any tag and then search for the desired tag on all the videos. The tag WILL appear in the "tags" property so you just have to check each tags property, but for whatever reason tumblr api doesn't pull them by tag.

example: http://sports.tumblr.com/tagged/NCAA

There is one video with the id 45977285406 and tag NCAA. If you do an api request for /videos and the NCAA tag nothing shows up.

I'd fix this if I knew java, but I don't know enough about it to manage it.

4pr0n commented 9 years ago

Thanks for the bug report and the potential solution I don't have time now but maybe someone else does.

The change will likely need to happen here:

https://github.com/4pr0n/ripme/blob/master/src/main/java/com/rarchives/ripme/ripper/rippers/TumblrRipper.java#L77-L84

That's where the ripper assumes "video" can be fetched the same as "photo".