search

4pr0n / ripme

Downloads albums in bulk
MIT License
914 stars 205 forks source link

Furaffinity ripper is broken #253

Open Wiiplay123 opened 8 years ago

Wiiplay123 commented 8 years ago

I'm getting Error: null on latest version. According to Eclipse, threads are being rejected after about 55- 60 are queued on the furaffinity ripper.

4pr0n commented 8 years ago

Looks like a bug in the description-fetching code. I didn't write this but I tried to fix it in v1.2.1.

Wiiplay123 commented 8 years ago

Oops. I wrote the description-fetching code but I tried to comment it as much as possible so other people could repair the code if it ever stopped working (like a site update or something) but I don't have time to fix it right now :(

4pr0n commented 8 years ago

Here's where I tried to fix it if you want to see: https://github.com/4pr0n/ripme/commit/5af0f95a3a290c743cb3170ff5c5dd4f2f3e1dc3#diff-35459ab0c5c294f2fbe556d4abfbdfe6

I was getting IndexOutOfBounds errors on Line 159; the .get(0) was on an empty array.

rautamiekka commented 7 years ago

Does this rejection have visible symptons ? On RipMe 1.2.13 and Oracle Java SE 8u112 x64 the only symptons and/or something being wrong Error: no images found at https://www.furaffinity.net/gallery/annamay18, nothing about null.

Wiiplay123 commented 7 years ago

Looks like FurAffinity has a captcha now on login. What do we do now?

Wiiplay123 commented 7 years ago

I figured out a temporary patch for me personally (a.k.a. I'm not making a commit for it) that's really not user friendly at all and requires pasting all the cookies from login when you first rip a furaffinity gallery after each time you start the program. Should hold me over until someone figures out a better way of doing it.

cyian-1756 commented 7 years ago

@Wiiplay123 Did you try my PR here? last time I tested it (Over a month ago) it worked

Wiiplay123 commented 7 years ago

@cyian-1756 That won't work on anything that requires you to be logged in to see, like mature and adult content. The ripme FurAffinity account changed passwords, probably when FurAffinity did that thing and reset everyone's passwords to random ones because of some security issue. And then they added captcha and made it even HARDER to log in automatically. Check out my temporary fix I'm having to use on the kindafixed_fa branch of my fork to see what I had to do to "fix" it. (I'm getting tons of images downloaded that I've been missing ever since RipMe's account had its password reset now!) Whoever owns the account needs to fix it so that ripme can log in again, and figure out a way to bypass captcha without manually pasting cookies in every time.

metaprime commented 7 years ago

@Wiiplay123 Probably easier to make a new account and integrate the credentials into the next update. I'll look into this.

metaprime commented 7 years ago

I merged #480 -- does that improve things?

Wiiplay123 commented 7 years ago

@metaprime The problem with simply making a new account and integrating the credentials into the next update is that the login has a CAPTCHA now, so even with correct account credentials the CAPTCHA still has to be solved somehow.

metaprime commented 7 years ago

@Wiiplay123 I understand. However, these are two separate issues that both need to be resolved, right?

metaprime commented 7 years ago

If cookies are a solution, there's a PR which will enable cookie support, and then you can add cookie values to the config. I agree that's not ideal from a UI perspective. We probably need to build a UI around it to import relevant cookies from a browser of choice. However, as a starting point, it's much better than hardcoding it into the application and having to build from there.