search

4pr0n / ripme

Downloads albums in bulk
MIT License
914 stars 205 forks source link

e-hentai: Hi-Res picture capture #528

Open zakalwe0514 opened 7 years ago

zakalwe0514 commented 7 years ago

Thanks to cyian-1756 for the fix to e-hentai for basic images!

This is an enhancement request.

Would it be possible to also add the capability to capture the hi-res version of images where it exists?

Sample Album: https://e-hentai.org/g/1022686/9d910dfe81/

Look at Image 1 (https://e-hentai.org/s/eb6bd303cb/1022686-1). This is the basic in-line image and is what ripme grabs by default.

Now look at Image 48 (https://e-hentai.org/s/83be9ff73b/1022686-48). In addition to the in-line image, there is a hyperlink to a larger file at the bottom of the page (https://e-hentai.org/fullimg.php?gid=1022686&page=48&key=3uu9f378wab) wrapped by the text " Download original 2296 x 3420 349.1 KB source". Obviously the image size and file size change. This would be the preferred pull if ripme can handle that.

Thanks!

metaprime commented 7 years ago

Looks like the high-res images are behind a log-in. We might need to use cookies here. There's a PR out that would support adding cookies to the config for things like this. (#354)

Looks like it wants you to log in to the forums. If you make an account for forums.e-hentai.org you get some cookies. Copying these two cookies into another browser allowed me to download the picture:

.e-hentai.org | ibp_member_id
.e-hentai.org | ibp_pass_hash

It appears no other information was necessary.

Once cookie support is merged, I'll add a check for these cookies in the config and then attempt to download such links using those cookies.

zakalwe0514 commented 7 years ago

You guys rock!

As an aside, I tried to add the Enhancement tag myself to save you the work. Is that something only you can do?

metaprime commented 7 years ago

@zakalwe0514 I think only people explicitly added to the repo as "Collaborators" (or better: Owner, Admin) can set tags on issues. As of now, I think @4pr0n is the only one with the ability to add more Collaborators, and I'm the only Collaborator (or better) besides him. I'm pretty sure I'm the only active one. :shrug: