search

4pr0n / ripme

Downloads albums in bulk
MIT License
916 stars 204 forks source link

Dead code in ImgurRipper #583

Closed cyian-1756 closed 7 years ago

cyian-1756 commented 7 years ago

Looking over the imgur ripper there seems to be a lot of dead code. For example this JSON ripping block doesn't work and I doubt it has for a while

There's also this /noscript fallback which as far as I know hasn't worked in over a year It looks like the noscript fallback works, I could've sworn the imgur removed it last year

metaprime commented 7 years ago

Yes, I wouldn't be surprised if we've got a ton of dead code. I approve removing it. Just ensure there are no regressions in mvn test

metaprime commented 7 years ago

Looks to be closed in ripmeapp/ripme#6