search

4refr0nt / ESPlorer

Integrated Development Environment (IDE) for ESP8266 developers
http://esp8266.ru/esplorer/
GNU General Public License v2.0
1.23k stars 325 forks source link

Lua 5.3 scripts: problem with '>>' #88

Open alex85k opened 4 years ago

alex85k commented 4 years ago

I am using ESPLorer to experiment with newer NodeMCU firmware built with make LUA=53

There are problems when code includes newly introduced right shift operator >> like

a=7
b=a>>3

When saving the script to flash the process hangs and module reboots. The problem is in these 2 lines of code checking the module answer: https://github.com/4refr0nt/ESPlorer/blob/142ff90e6af26ef845880eb21c023c372bead3c4/src/main/java/ESPlorer/ESPlorer.java#L12038

   data = data.replace(">> ", "");
   data = data.replace(">>", "");

(I commented them for myself, it seems to work)

marcelstoer commented 3 years ago

As Lua 5.3 will become the standard sooner or later (see https://github.com/nodemcu/nodemcu-firmware/issues/3144#issuecomment-944456112 from @TerryE) this should be addressed.