4seer
commented
4 years ago Bloc can give the same results as Get It. If we will use BLOC, it can give the same dependency injection functionality as GetIt. Screen can have no mentions of repository classes. Additionally just as a variant - NetworkRequest class. Sometimes it is not a good idea to wrap all requests in WoocommerceWrapper implementation as it is in your code right now. It will require different input parameters and sometimes output shouldn't be json decoded. And why should it be provided globally? With my network request, it can be easier to maintain parameters. Or maybe I just don't like to have so much global singletons. :)
May be you just don`t like to have so much global singletons.
I relocated your class NetworkRequest and SortRules json conversion right in the development branch. Not using it anywhere. Will possible refactor the code and utilize it.
If there is nothing more than that, please, remove pull request and let me know.
Bloc can give the same results as Get It. If we will use BLOC, it can give the same dependency injection functionality as GetIt. Screen can have no mentions of repository classes. Additionally just as a variant - NetworkRequest class. Sometimes it is not a good idea to wrap all requests in WoocommerceWrapper implementation as it is in your code right now. It will require different input parameters and sometimes output shouldn't be json decoded. And why should it be provided globally? With my network request, it can be easier to maintain parameters. Or maybe I just don't like to have so much global singletons. :)