search

4seer / openflutterecommerceapp

Open Flutter E-commerce App
GNU General Public License v3.0
849 stars 387 forks source link

Add fonts to the App #96

Closed 4seer closed 1 year ago

4seer commented 4 years ago

We need to add fonts to the app. Font used in design: Metropolis

Possible solution: https://pub.dev/packages/google_fonts

Mastersam07 commented 4 years ago

Can I pick up this issue?

4seer commented 4 years ago

Can I pick up this issue?

You can always propose your solution with a pull request into development branch.

Mastersam07 commented 4 years ago

Okay the

Can I pick up this issue?

You can always propose your solution with a pull request into development branch.

Okay then

4seer commented 4 years ago

Fonts do not look like in design after adding font. Font style "Metropolis-black" should be added for titles and other. Compare what is in the app and how it should be in design https://medium.com/@openflutterproject/open-flutter-project-e-commerce-app-fe97570a633

umair13adil commented 4 years ago

Yes, I noticed that too. The fonts on each screen need to be adjusted, I will do that, I was waiting for this commit to be reviewed.

4seer commented 4 years ago

We just need to add appropriate fontWeight so it will be used according to the design.

umair13adil commented 4 years ago

Okay, I will make sure of that.

4seer commented 4 years ago

Here is a an example https://github.com/4seer/openflutterecommerceapp/commit/d2747349e2a6a84b99ba6ed7f7342246e6cdb60b

4seer commented 4 years ago

Okay, I will make sure of that.

Hello Umair! Did you finish all updates within this task?

RasheeqZaman commented 1 year ago

Hi, I was looking forward to making some contribution to this project. Is this issue resolved already?

4seer commented 1 year ago

Hi, I was looking forward to making some contribution to this project. Is this issue resolved already?

Umair did his part. There are some lint warning left. You proceed with your contribution. Make a pull request and we will review it.