search

4site-interactive-studios / engrid

The Unlicense
10 stars 4 forks source link

Adjust Giving Frequency Live Variable for "Annual" giving #35

Closed bryancasler closed 3 years ago

bryancasler commented 3 years ago

When "Annually" giving is selected, the value of the field is "Annual" and if $FREQUENCY is used on the Submit button it will read something like "Give $50 Annual". This should be updated so that if "annual" is selected the text output is "Annually". We should not use the field label because a client might put "GIve Annually" and it can't be trusted. Instead, we should just detect the "Annual" value but output "Annually" as $FREQUENCY

bryancasler commented 3 years ago

Here is the line

https://github.com/4site-interactive-studios/engrid-scripts/blob/90e85674783cdf17806dcfe2fd71ef5c4cb48dc0/packages/common/src/live-variables.ts#L68

Additional logic should be added to that when frequency = "annual" (case insensitive) it should output as "annually"