search

4spacesdk / CI4OrmExtension

OrmExtension for CodeIgniter 4
MIT License
50 stars 9 forks source link

php >= 8.x compatibility #15

Closed etcware closed 2 years ago

etcware commented 2 years ago

We tried the library both with php 7 and php 8 and in this case we receive an error that seems this https://wiki.php.net/rfc/abstract_trait_method_validation that is implemented in php 8. We don't go deeply because may there other problems, but to be inline with CI that is compatible with php 8 this library should be the same.

Martin-4Spaces commented 2 years ago

Thank you for raising this issue. I’ll take a look at php8.

Den 24. dec. 2021 kl. 06.25 skrev Alex @.***>:

 We tried the library both with php 7 and php 8 and in this case we receive an error that seems this https://wiki.php.net/rfc/abstract_trait_method_validation that is implemented in php 8. We don't go deeply because may there other problems, but to be inline with CI that is compatible with php 8 this library should be the same.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.

markkortleverwebavance commented 2 years ago

Hi,

Any idea if and when there will be an update to make the package php8 compatible?

Martin-4Spaces commented 2 years ago

I hope to have time for this next week.

On 7 Feb 2022, at 14.01, markkortleverwebavance @.***> wrote:

Hi,

Any idea if and when there will be an update to make the package php8 compatible?

— Reply to this email directly, view it on GitHub https://github.com/4spacesdk/CI4OrmExtension/issues/15#issuecomment-1031443313, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACK5H5AVK7ESTVNPYUXN3XDUZ67BZANCNFSM5KWBLAYA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

Martin-4Spaces commented 2 years ago

Here we go https://github.com/4spacesdk/CI4OrmExtension/releases/tag/1.0.3. Let me know if you encounter any issues.