4tals / LinksForIsrael

פורטל יוזמות - חרבות ברזל
https://linksforisrael.com
23 stars 25 forks source link

Move to a single link per initiative (previously: Support multiple links for a single entry) #116

Open ohadschn opened 1 year ago

ohadschn commented 1 year ago

UPDATE I'm thinking we might want to go the other way and simplify everything with a single link to the initiative's main site:

  1. We won't need to maintain (number of initiatives) * (average number of links) links
  2. We simplify our data JSONs - basically we keep just the main (url) property
  3. We simplify the new initiative form and the corresponding user experience
  4. This is the standard in all other aggregator sites

This might fit well with the new design as an opportunity to reduce load: @Anatolysco / @4tal / @omer-friedman / @yanai101

PREVIOUS TEXT:

For example, see: https://github.com/4tal/LinksForIsrel/issues/115 There is a hotline number, as well as an e-mail Either one can be linked, but not both We can either support it natively (similar to the multiple share links we have for categories), or link to some "bio" site with contact information where there are links to e-mail, whatsapp, phone# etc

ohadschn commented 1 year ago

@4tal I would say the current implementation is partial, as it allows only one link per type (for example, only one WhatsApp link). This would be a problem in the common case where the same initiative has multiple forms (typically one for requesting help and one for offering help). I think a better implementation would be something like:

{
    "name": "foo",
    "displayName": "FOO help",
    "shortDescription": "Helping foo",
    "links": [
        {
            "type": "facebook",
            "url": "https://m.facebook.com/groups/780925150471197/?ref=share&mibextid=lURqYx"
        },
        {
            "type": "form",
            "description": "offer help", 
            "url:": "https://chat.whatsapp.com/Bsy4Sc9jM4PIS64JD1aRnp"
        },
        {
            "type": "form",
            "description": "request help", 
            "url:": "https://chat.whatsapp.com/xkjhl1kjh4PIS64JD1aRnp"
        }
    ]
}
4tal commented 1 year ago

Current model can support and it's kind of working like that. Can you suggest situation where we'll need to use id per link in the near future? or use case current format don't support.

ohadschn commented 1 year ago

Current model can support and it's kind of working like that. Can you suggest situation where we'll need to use id per link in the near future? or use case current format don't support.

I don't follow, I did exactly that in the comment above - use case that isn't supported and is needed... To illustrate further, In the current format, you can't do this:

{
          "name": "AtarMearhim",
          "displayName": "אתר מארחים",
          "shortDescription": "",
          "description": "אתר לחיפוש בתים מארחים למשפחות",
          "forms1": "https://mearhim.vercel.app", //form for home hosters
          "forms2": "https://mearhim.vercel.app", // form for home seekers
}
chiptus commented 1 year ago

I think this is related to https://github.com/4tals/LinksForIsrael/issues/206

at least to the bottom line:

or example, anything social will automatically get [instagram, twitter, facebook, tiktok])

ohadschn commented 1 year ago

I think this is related to #206

at least to the bottom line:

or example, anything social will automatically get [instagram, twitter, facebook, tiktok])

You mean moving the tag to the link (rather than the initiative) level? Something like

"links": [
        {
            "type": "facebook",
            "url": "https://m.facebook.com/groups/780925150471197/?ref=share&mibextid=lURqYx",
            "tags": ['facebook']
        },

Are you sure that makes sense? To me it sounds like tags should remain at the initiative level - for example, when used for search what you'll find is the initiative, not any specific link...

ohadschn commented 1 year ago

@4tal I think this became more important when agriculture groups started to be involved. Many of those initiatives are basically a collection of WhatsApp groups, so we need multiple WhatsApp links for the same initiative.

ohadschn commented 1 year ago

@omer-friedman if you're thinking about the next issue to tackle, may I suggest this?

Looking at the rides / transportation category, again there are basically a million groups, and we could just have one "initiative" called "whatsapp groups" with multiple whatsapp links, where something like a hover over each one gives you its name and short description

The same could be done for general assistance, strategic communication, agriculture (and as mentioned above)...

omer-friedman commented 12 months ago

It would be great if we'll have a UX/UI for this one. @4tal can you talk with vitali about it?

ohadschn commented 12 months ago

It would be great if we'll have a UX/UI for this one. @4tal can you talk with vitali about it?

I don't think we have to wait, IMO even something as simple as having the same icon multiple time with a differentiating hover would be better than no support at all...

BTW @omer-friedman such a hover over each link would be useful even without multiple links - for example an initiative might have just one form, but what form? Volunteer signup? Ask for help? Fill info to get more details? etc.