search

4tals / LinksForIsrael

פורטל יוזמות - חרבות ברזל
https://linksforisrael.com
23 stars 25 forks source link

English-only filtered view (previously: Globalization support) #53

Open michaeltastewise opened 1 year ago

michaeltastewise commented 1 year ago

A fair amount of people came to Israel in the last years or sometimes even live here for a while not knowing Hebrew all that well. It should be fairly easy for us to quickly translate everything to a reasonable™ version.

ohadschn commented 1 year ago

Related issue: https://github.com/4tal/LinksForIsrael/issues/102. I think that when English is selected, the link above should be at the top in bold (I'm guessing the vast majority would be visitors from abroad who just want to donate money)

ohadschn commented 1 year ago

Perhaps we could start with a low effort solution that gets us 90% of what we need: https://www-linksforisrael-com.translate.goog/?_x_tr_sl=en&_x_tr_tl=iw&_x_tr_hl=en&_x_tr_pto=wapp

Couldn't quite find it documented, but it looks like it works like this: https://www-linksforisrael-com.translate.goog/?_x_tr_sl=XX&_x_tr_tl=YY Where XX = source language, in our case iw (short for iwrit/ hebrew) and YY = target language, would be en, es etc.

Breakdown is as follows:

I suspect this might break some time in the future (as I couldn't find proper docs), but for now should be good enough...

ohadschn commented 10 months ago

@4tal I don't think globalization is needed per se, but how about the following:

  1. Have some URL we can send English speakers to (e.g. https://www.linksforisrael.com/?lang=en).
  2. Use the logic introduced by @omer-friedman in https://github.com/4tals/LinksForIsrael/issues/481 to detect English initiatives (namely description contains zero Hebrew characters) and filter the view to show only them.
  3. Have some JSON property/flag to override the above logic (e.g. globalized: true).
  4. Use the English category and subcategory names (which we already have in the JSON structure) - need to fix them up a little before though per https://github.com/4tals/LinksForIsrael/issues/610.