Possibly restore Plone 4.1 compatibility

[lukasgraf]

Currently ftw.builder is still used by some packages that offer Plone 4.1 compatibility (ftw.contentpage and ftw.contenttemplates) to name just two).

Because the recent change from #32 now unconditionally imports the Dexterity builders, ftw.builder will fail on Plone 4.1 because Dexterity isn't shipped by default up until Plone 4.2.

We have a couple options here:

• Drop 4.1 support in those packages
• Restore 4.1 compatibility in ftw.builder by either
  • making all Dexterity imports conditional on the Plone version (or the availability of plone.dexterity). This currently would require defining a HAS_DEXTERITY somewhere, and making the imports in content.py and test_content.py conditional
  • or adding plone.app.dexterity to ftw.builder's requirements in setup.py and extending from the old-style Dexterity KGS in test-plone.4.1.x.cfg. This would also require the test-plone-4.1.x.cfg from ftw-buildouts to extend from the DX KGS though, not sure what the implications of that would be.

@jone @maethu @phgross @deiferni

What do you think?

[jone]

Oh, didn't see that coming. We have no 4.1 test (and thus no official support) because we test Dexterity builders with p.a.contenttypes, which is hard to install for 4.1.

I would just move the imports DexterityBuilder (and ArchetypesBuilder) in content.py into the if / else, so that other packages can use the builder with Plone 4.1 again (although still not officially supported).

We could add 4.1 tests, but I think we'd either have to ignore all dexterity tests or at least stop using p.a.contenttypes in tests..

[lukasgraf]

Yeah, I think there's two separate issues here: Not breaking support for using ftw.builder with 4.1 vs. actually testing ftw.builder with 4.1.

I'd also tend to go with the pragmatic approach and just make the imports conditional wherever it's needed.

[lukasgraf]

@jone this should do the trick.

[lukasgraf]

sigh seems we would also have to check for the availability of Named Blob File.

This is getting pretty ugly, but this would deal with the Named[Blob]File issue:

if HAS_DEXTERITY:
    from plone.namedfile.interfaces import HAVE_BLOBS
    from ftw.builder.dexterity import DexterityBuilder
    if HAVE_BLOBS:
        from plone.namedfile.file import NamedBlobFile as NamedFile
    else:
        from plone.namedfile.file import NamedFile

# ...

    self.attach(NamedFile(data=content, filename=name))

[jone]

@lukasgraf how is HAVE_BLOBS? Looks like it is always True. Which package / build is failing without this change? Can you do the change? I'd like to have this PR merged and released as soon as possible, so that the builds are green again..

[jone]

Let's ship this one; we can fix the namedfile issue separately.

[jone]

I've release 1.5.0.

[jone]

I've fixed the blob issue in #35 as discussed above and released with 1.5.1. (The 1.5.0 release helped me track it down and debug it :wink: )