search

4teamwork / ftw.builder

Builder pattern for creating Plone objects in tests
3 stars 0 forks source link

Added dexterity support. #6

Closed phgross closed 11 years ago

phgross commented 11 years ago

I've added simple dexterity support for the builder API, including a own DexterityBuilder.

@jone @senny could you take a look?

senny commented 11 years ago

Should we also ship some default dexterity Builders? Would they conflict with the archetype Builders?

senny commented 11 years ago

@phgross sorry for commenting on the commit :grimacing:

jone commented 11 years ago

@senny with only dexterity installed, there are no default types (yet), therefore I'd not ship any default builders until the default types make it into core. There is a addon replacing the Archetypes types with Dexterity types (File, Folder, etc) but this is very optional..

phgross commented 11 years ago

@senny and @jone: I did some changes on the DexterityBuilder according to your comments.

Additionally i refactored the object creating process, so that it's not longer necessary to notify the events in the builder itself.

Could you take another look? Thx!

phgross commented 11 years ago

@Jone I improved the method names, implemented checkConstraint in to a instance attribute and improved the readability of the set_missing_values_for_fieldmethod.

Could you take another look.

phgross commented 11 years ago

@jone I removed the not necessary import and rebased the commits.