4teamwork / ftw.inflator

Plone site setup wizard with content creation and bundle system for predefined configurations.
3 stars 6 forks source link

Fix multilingual import error in Plone 5. #28

Closed gyst closed 8 years ago

jone commented 8 years ago

Awesome, thanks!

gyst commented 8 years ago

Thanks for merging! Can I have a release, I need this for a current project and would rather not depend on a source checkout.

jone commented 8 years ago

@gyst I have released ftw.inflator = 1.8.1 with this change 😉

szakitibi commented 6 years ago

Based on plone.app.multilingual versions info:

2.x - Plone >= 4.x, < 5.0 with plone.app.contenttypes (Dexterity) and real shared content

But Plone >= 4.x does not have the ILanguage interface yet, it is added only in Plone 5.0

Current import solution falls back to version 1.x even if it has 2.x with Plone 4.3.x - see https://github.com/4teamwork/ftw.inflator/pull/28/commits/786e2f81a0e8854131b97a0de1aeb64156b2928b#diff-9982ea59ed18845760077bc5630e7244L25.

Means this import produces error for Plone 4.3.x + plone.app.contenttypes + plone.app.multilingual 2.x combo.