Add test - Githubissues

4teamwork / ftw.linkchecker

0 stars 0 forks source link

Add test #23

Closed busykoala closed 5 years ago

busykoala commented 5 years ago

Close #20 Close #18

Test being added:

Are external links detected?
Are broken relations found?
Does the excel report generator work correctly?
Does the mail sender correctly send an email including attachment?

Additional Changes needed to implement tests:

Adapt excel generator (remove function calls in module outside class). (Close #8 )

busykoala commented 5 years ago

@maethu könntest du beim Review schauen, ob nirgends ein Objekt aufgerufen wird/werden kann, welches Inhalte löschen würde?

maethu commented 5 years ago

I stopped reviewing at some point... it's just too much and quite noise. I come over and we can discuss some points right away.

Generally:

Use setUp/tearDown (and move the code there)
Make more small tests instead of large ones with a lot of comments.
Maybe use more helper methods in tests to improve readability. Imagine in a year a test fails and you have to fix it.
Love the fact that you have 2 plone site up and running ❤️ ✨

busykoala commented 5 years ago

I remodelled the code quite a bit moving the test setup to the layer setup. Could you please look at it again? Please create issues for anything not concerning the tests itself so the pull does not grow into infinity.