4teamwork / ftw.linkchecker

0 stars 0 forks source link

Better way to pass over timeout configuration #44

Closed busykoala closed 5 years ago

busykoala commented 5 years ago

Instead of defining it with a global variable we could just pass it to get_uri_response.

Setting a global variable in a function makes only an option if it's really necessary. Since it makes debugging and analysing the code unnecessary more difficult. It could be set anywhere in that file.

https://github.com/4teamwork/ftw.linkchecker/pull/42#discussion_r253634424