search

4teamwork / ftw.linkchecker

0 stars 0 forks source link

Refactor the accumulator module. #91

Closed busykoala closed 4 years ago

busykoala commented 4 years ago

🚧 Do not merge yet 🚧

close #79

I tried to do little steps for the refactoring by splitting it into different commits. Maybe not all of them make sense on their own but will if they are in larger context (especially I tried to minimize the diff so that one can tell what actually changed and what was only moved).

busykoala commented 4 years ago

I hope the refactoring done helps understand the code better. It still did not touch how things are done actually but I tried to split the code by functionality. Having methods with descriptive names helps to understand what the steps actually do.

busykoala commented 4 years ago

I split up the public method of ArchetypeSeeker (the one you suggested) in cb1ab9e. At least for me, it makes more sense right now the way I changed it ;-)