Closed lukasgraf closed 5 years ago
@lukasgraf can you rebase HISTORY.txt
?
@buchi rebased - I proposed 2.3.0
for the upcoming version, because it's a rather significant change. But we could also release your change on master
as a separate version, and I'll rebase on that again. I don't mind either way.
This re-applies the patch we originally had in the
ftw.solr 1.x
line.This patch optimizes
CatalogAware.reindexObjectSecurity()
so that it performs substantially better for large trees of objects. The optimization relies on the fact that when recursively reindexing security for a subtree, recursion can safely be terminated as soon as an object is encountered that didn't experience a change to the contents of its indexed security.Without this patch, and
collective.solr == 2.0
theallowedRolesAndUsers
index won't be properly updatedcollective.solr == 2.1
theallowedRolesAndUsers
index will be updated, but in a very inefficient wayWith this patch, irrespective of the version of
collective.solr
,allowedRolesAndUsers
will be properly updated in an efficient fashionReasoning why terminating recursion early is safe
(copied from the respective docstring)
See 4teamwork/opengever.core#4759 for some more background.