4teamwork / ftw.solr

Solr integration for Plone
5 stars 5 forks source link

Fix solr sync maintenance command not committing all batches. #196

Closed lukasgraf closed 1 year ago

lukasgraf commented 1 year ago

Fix solr sync maintenance command not committing all batches.

Because the maintenance view doesn't commit the ZODB transaction, Solr commits must not be deferred into a ZODB transaction post commit hook in this view, otherwise they won't get executed.

This lead to the last (or only) batch of items not getting committed (discovered during GDGS recovery).

This was partially addressed in #191, but some conn.commit()'s were missed (or maybe introduced later)