search

4teamwork / ftw.solr

Solr integration for Plone
5 stars 5 forks source link

Implement accessibility support for solr facets. #55

Closed bierik closed 8 years ago

bierik commented 8 years ago

According to access4all the facets of the solr search has to be reachable with the keyboard.

Go trough the filter by hitting tab. This will focus the filter.

Controls on the filter:

Controls on open filter:

facets_accessiblity

bierik commented 8 years ago

@maethu HTML and changelog added

maethu commented 8 years ago

@bierik The browser window moves down on certain "down arrow" clicks.

screen shot 2016-02-23 at 09 34 04
maethu commented 8 years ago

pls rebase too.

maethu commented 8 years ago

@bierik How can I select/choose a facet?

bierik commented 8 years ago

@maethu updated

maethu commented 8 years ago

@bierik Removing a facet has still the relattribute?

maethu commented 8 years ago

Searching is no longer possible?????? Seems like the enter key no longer works.

pls fix asap!

bierik commented 8 years ago

@maethu I got out of control when trying to style the search form. The nesting in the current implementation is too deep to predict the impacts when touching the styles. So in https://github.com/4teamwork/ftw.solr/commit/f2289c4d14817cec2c623ddb8973b05fb1e2069f I tried to rewrite the styling to make it less complex. I removed the .no-border style definition because I don't know what this thing is doing actually.

maethu commented 8 years ago

It's OK to change things... but ftw.solr is used in several environments, for example with plonetheme.onegov. Markup changes makes it hard to keep up :disappointed_relieved:

I'm not sure how to deal with this... But usually if you change the markup we need to change a lot of things, like every theme we have in use.

Now it may work for plonetheme.onegovbear, but what about plonetheme.onegov? or other themes, which uses the regular solr.css.

maethu commented 8 years ago

I've added to fixes to your branch: