4teamwork / ftw.testbrowser

A testing browser for Plone.
http://ftwtestbrowser.readthedocs.io/
5 stars 1 forks source link

Use open from io for python2/3 compatibility. #102

Closed busykoala closed 4 years ago

busykoala commented 4 years ago

Close https://github.com/4teamwork/ftw.testbrowser/issues/101

Since the default mode changed in python3 [*1] we should use from io import open to make it compatible with both versions in core.py. This is relevant for e.g. browser.debug()

busykoala commented 4 years ago

Good work, just clearer comment maybe?

What would you suggest?

djowett-ftw commented 4 years ago

Explain what was going wrong, then the solution. No? ;-)