search

4teamwork / ftw.testbrowser

A testing browser for Plone.
http://ftwtestbrowser.readthedocs.io/
5 stars 1 forks source link

plone.protect is not a requirement #71

Closed jone closed 7 years ago

jone commented 7 years ago

plone.protect is imported but not declared as a dependency: https://github.com/4teamwork/ftw.testbrowser/blob/72df4bed423d515f40c26cdf0e911f2d7a73e88e/ftw/testbrowser/core.py#L30

ftw.testbrowser cannot depend on plone.protect: the import should be wrapped in a pkg_resources check, like: https://github.com/4teamwork/ftw.testbrowser/blob/72df4bed423d515f40c26cdf0e911f2d7a73e88e/ftw/testbrowser/core.py#L44-L51