search

4teamwork / ftw.upgrade

An upgrade control panel and upgrade helpers for plone upgrades.
6 stars 10 forks source link

Make "six" a direct dependency #198

Closed mbaechtold closed 4 years ago

mbaechtold commented 4 years ago

This Plone addon makes use of six a lot, but it is not declared as a direct dependency in setup.py.

I propose to add it to the setup.py and require at least 1.12.0 because this code base uses six.ensure_text which was added only in 1.12.0 (see `https://github.com/benjaminp/six/blob/3a3db7510b33eb22c63ad94bc735a9032949249f/CHANGES#L39).

This will solve the failing test setup of other software packages making use of ftw.upgrade but having an older version of six.

@buchi, what do you think about this issue?

mauritsvanrees commented 4 years ago

👍 PR merged, issue can be closed.

buchi commented 4 years ago

Yep, six >= 1.12.0 should be added to install_requires.

However this will not solve issues with setups that pin an older version of six. Buildout will just fail with a bad constraint error. You will have to bump your version pin anyway.

mbaechtold commented 4 years ago

I'm reopening this issue because the corresponding pull request https://github.com/4teamwork/ftw.upgrade/pull/199 has not been merged yet.

mbaechtold commented 4 years ago

But as I'm working through my GitHub notifications, I just noticed that the pull request has been approved by @maethu. I have merged the pull request and this issue has bene closed automatically.