search

4teamwork / ftw.workspace

A project folder for plone.
3 stars 0 forks source link

Update workflows due to a new permission in ftw.file 1.16.0. #93

Closed mbaechtold closed 6 years ago

mbaechtold commented 6 years ago

This also updates the gettext message catalog which was out-of-date (see the separate commit).

elioschmutz commented 6 years ago

@mbaechtold 👍

One question: You're updating the workflow due to a new permission in ftw.file 1.6. But the ftw.workspace seems to work with lower versions too. There is no minimum version requirement for ftw.file in setup.py.

Should you pin the ftw.file dependency to >= 1.6 within the ftw.workspace setup.py? it would not break, but it refers to non exisiting permissions.

mbaechtold commented 6 years ago

Good point, @elioschmutz 👍 I have amended the commit.

elioschmutz commented 6 years ago

👍 perfect! 🚢