search

4teamwork / ftw.zipexport

Zip Export for Plone
2 stars 6 forks source link

zip_export view does not respect it's own settings #21

Closed maethu closed 10 years ago

maethu commented 10 years ago

it's possible to configure the zip download doc action.

screen shot 2014-05-05 at 09 21 42

But it's still possible to call the zip_download view on other content.

shylux commented 10 years ago

@maethu review please :)

maethu commented 10 years ago

@shylux you should raise Notfound in the calll method if the exportview is not allowed on the current context. Currently you check if the exportview is available on every item.

There's a difference between the export view, which actually iterates through all items and if the item has a zip representation.

shylux commented 10 years ago

@maethu updated

deiferni commented 10 years ago

@shylux could it be necessary to specify multiple interfaces for which to enable a zip-export in IZipExportSettings?

shylux commented 10 years ago

@deiferni already queued https://github.com/4teamwork/ftw.zipexport/issues/23

deiferni commented 10 years ago

:+1: